Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

"My Check-Ins" skeleton UI & prep work (EXPOSUREAPP-5410) #2619

Merged
merged 6 commits into from
Mar 16, 2021
Merged

"My Check-Ins" skeleton UI & prep work (EXPOSUREAPP-5410) #2619

merged 6 commits into from
Mar 16, 2021

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Mar 15, 2021 •
edited

  • Wiring up the UI a bit more
  • Some refactoring.
  • Graphics, layouts
  • Strings
  • QR Code tests that are not yet running, I'll follow with another PR for that

Testing

  • Look at the "My Check-Ins" screen, make sure everything you need to debug still works
  • Strings and graphics should be correct, other functionality will be part of a different PR.

@d4rken d4rken requested review from a team March 15, 2021 14:15
@d4rken d4rken added the maintainers Tag pull requests created by maintainers label Mar 15, 2021
@d4rken d4rken added this to the 2.0.0 milestone Mar 15, 2021
janetback
janetback previously approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed.

@d4rken d4rken mentioned this pull request Mar 15, 2021
Merged
@mtwalli mtwalli self-assigned this Mar 16, 2021
@BMItr BMItr self-assigned this Mar 16, 2021
@BMItr
Copy link
Contributor

BMItr commented Mar 16, 2021

code lgtm..
tested on pixel 2 & nexus 5 device (no issues found)
please resolve conflict & resolve comments when you are done.
Approve from my side (will reapprove after upcoming commit)

BMItr
BMItr previously approved these changes Mar 16, 2021
View reviewed changes
@d4rken
Merge branch 'release/2.0.x' into feature/5410-checkin-overview-skele…
182c601 
…tons

# Conflicts:
#	Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/eventregistration/checkins/qrcode/DefaultQRCodeVerifierTest.kt
@d4rken
Copy link
Member Author

d4rken commented Mar 16, 2021

Conflict was due to changes in protobuf, my solution for this PR was to comment it out, it will be overwritten in #2622

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

17.5% 17.5% Coverage
0.0% 0.0% Duplication

mtwalli
mtwalli approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4rken d4rken merged commit 625a2a4 into release/2.0.x Mar 16, 2021
@d4rken d4rken deleted the feature/5410-checkin-overview-skeletons branch March 16, 2021 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtwalli mtwalli mtwalli approved these changes

@BMItr BMItr BMItr approved these changes

@janetback janetback janetback left review comments

Assignees

@mtwalli mtwalli

@BMItr BMItr

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d4rken @BMItr @mtwalli @janetback