This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Use TraceLocationType enums from protobuf (DEV) #2624
Merged
LukasLechnerDev
merged 4 commits into
release/2.0.x
from
feature/DEV-Use-tracelocation-enum-from-protobuf
Mar 17, 2021
Merged
Use TraceLocationType enums from protobuf (DEV) #2624
LukasLechnerDev
merged 4 commits into
release/2.0.x
from
feature/DEV-Use-tracelocation-enum-from-protobuf
Mar 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good over all
...c/main/java/de/rki/coronawarnapp/eventregistration/storage/entity/TraceLocationConverters.kt
Show resolved
Hide resolved
...pp/src/test/java/de/rki/coronawarnapp/eventregistration/events/DefaultTraceLocationKtTest.kt
Show resolved
Hide resolved
...pp/src/test/java/de/rki/coronawarnapp/eventregistration/events/DefaultTraceLocationKtTest.kt
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
chiljamgossow
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LukasLechnerDev
deleted the
feature/DEV-Use-tracelocation-enum-from-protobuf
branch
March 17, 2021 10:05
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, we had our own enum for TraceLocationTypes.
This PR changes this to use the enum from the protobuf
TraceLocationOuterClass.TraceLocationType
.