Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Use TraceLocationType enums from protobuf (DEV) #2624

Merged

Conversation

LukasLechnerDev
Copy link
Contributor

Before this PR, we had our own enum for TraceLocationTypes.

This PR changes this to use the enum from the protobuf TraceLocationOuterClass.TraceLocationType.

@LukasLechnerDev LukasLechnerDev added the maintainers Tag pull requests created by maintainers label Mar 15, 2021
@LukasLechnerDev LukasLechnerDev added this to the 2.0.0 milestone Mar 15, 2021
@LukasLechnerDev LukasLechnerDev requested a review from a team March 15, 2021 16:00
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtwalli mtwalli self-assigned this Mar 16, 2021
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good over all

@chiljamgossow chiljamgossow self-assigned this Mar 17, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasLechnerDev LukasLechnerDev merged commit 0bc79cb into release/2.0.x Mar 17, 2021
@LukasLechnerDev LukasLechnerDev deleted the feature/DEV-Use-tracelocation-enum-from-protobuf branch March 17, 2021 10:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants