This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Minor string fixes (DEV) #2629
Merged
Minor string fixes (DEV) #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
previously approved these changes
Mar 16, 2021
|
Need to add some other minor corrections (changes to punctuation) -> setting to draft. |
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -12,7 +12,7 @@ | |||
| <string name="contact_diary_person_list_no_items_title">"Noch keine Personen vorhanden"</string> | |||
| <string name="contact_diary_person_list_no_items_subtitle">"Legen Sie eine Person an und fügen Sie sie in Ihrem Kontakt-Tagebuch hinzu."</string> | |||
| <string name="contact_diary_add_person_title">"Person"</string> | |||
| <string name="contact_diary_add_person_text_input_name_hint">"Vorname, Nachname"</string> | |||
| <string name="contact_diary_add_person_text_input_name_hint">"Name"</string> | |||
There was a problem hiding this comment.
Wasn't it agreed that it should be Vorname, Nachname?
There was a problem hiding this comment.
Hi @harambasicluka , checked with Martin Hermes. We believe that 'Name' was agreed upon. Also - this seems to be current implementation in iOS.
ralfgehrer
approved these changes
Mar 16, 2021
d4rken
approved these changes
Mar 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed 'Nachname, Vorname' to just 'Name' (specific request from RKI);
Changed punctuation on risk card;