Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Event registration - create event homescreen tile (EXPOSUREAPP-5411) #2636

Merged
merged 13 commits into from
Mar 22, 2021
Merged

Event registration - create event homescreen tile (EXPOSUREAPP-5411) #2636

merged 13 commits into from
Mar 22, 2021

Conversation

SamuraiKek
Copy link
Contributor

  • Adds the create event tile on the homescreen for the organizer flow.
  • Navigation from the tile will be added in a later PR.
  • Strings are temporary

@SamuraiKek SamuraiKek added the maintainers Tag pull requests created by maintainers label Mar 17, 2021
@SamuraiKek SamuraiKek added this to the 2.0.0 milestone Mar 17, 2021
@SamuraiKek SamuraiKek requested review from a team March 17, 2021 15:27
mtwalli
mtwalli reviewed Mar 18, 2021
View reviewed changes
Corona-Warn-App/src/main/res/layout/home_create_event_card.xml Outdated Show resolved Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeAdapter.kt Outdated Show resolved Hide resolved
Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml Outdated Show resolved Hide resolved
Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml Outdated Show resolved Hide resolved
Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml Outdated Show resolved Hide resolved
Corona-Warn-App/src/main/res/values/event_registration_strings.xml Outdated Show resolved Hide resolved
Corona-Warn-App/src/main/res/layout/home_create_event_card.xml Outdated Show resolved Hide resolved
Corona-Warn-App/src/main/res/layout/home_create_event_card.xml Outdated Show resolved Hide resolved
@mtwalli mtwalli self-assigned this Mar 18, 2021
@LukasLechnerDev LukasLechnerDev self-assigned this Mar 18, 2021
@SamuraiKek
Removed databinding <layout> and added more space between text and im…
d37da3a 
…age.
@SamuraiKek
Merge branch 'release/2.0.x' into feature/5411-create-event-tile
b290f54 
# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentViewModel.kt
LukasLechnerDev
LukasLechnerDev approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for the wording change!

mtwalli
mtwalli approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Tested on Samsung S8

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
40.0% 40.0% Duplication

janetback
janetback approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

@harambasicluka harambasicluka merged commit 71415ef into release/2.0.x Mar 22, 2021
@harambasicluka harambasicluka deleted the feature/5411-create-event-tile branch March 22, 2021 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

@mtwalli mtwalli mtwalli approved these changes

@janetback janetback janetback approved these changes

Assignees

@LukasLechnerDev LukasLechnerDev

@mtwalli mtwalli

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SamuraiKek @LukasLechnerDev @mtwalli @janetback @harambasicluka