Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Check-In risk level transmission (EXPOSUREAPP-5770) #2641

Merged
merged 33 commits into from
Mar 23, 2021
Merged

Check-In risk level transmission (EXPOSUREAPP-5770) #2641

merged 33 commits into from
Mar 23, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 18, 2021 •
edited

  • Finalise check-ins submission steps and map to server check-ins
  • Put all Check-in submission in order as per specs
  • Adjusting plausible deniability and (server request changes) will follow up in another PR

Testing

  • Please check the specs and see if there anything missing
  • Register a test and submit your keys (should not be affected by this change)

@harambasicluka harambasicluka added the maintainers Tag pull requests created by maintainers label Mar 18, 2021
@harambasicluka harambasicluka added this to the 2.0.0 milestone Mar 18, 2021
@mtwalli
Put submission steps together
a24b0d9
@mtwalli
Default values
2b3981b
@mtwalli
Fix tests
1d69277
@mtwalli
klint
3eba778
@mtwalli
Prepare test data
63b8615
@mtwalli
Merge branch 'release/2.0.x' into feature/5770-check-in-risk-transmis…
5830fd5 
…sion
@mtwalli
Docs and improvements
f19d203
@mtwalli
Risk transmission tests
1c8e6c2
@mtwalli
Negative age
6069c8b
@mtwalli
Simplify default value logic
4c343bc
@mtwalli
CheckIn assertions
d11b5d2
@mtwalli
Use specific date
52178d0
@mtwalli
Improvements of logging and mapping
26575f7
@mtwalli
Mark the class with Singleton - move log statement
61d44ff
@mtwalli
Assertion for splitted check-in
69c0b02
@mtwalli
Merge branch 'release/2.0.x' into feature/5770-check-in-risk-transmis…
db66f14 
…sion
@mtwalli
Adopt CheckIn changes
68d5865
@mtwalli
Merge branch 'release/2.0.x' into feature/5770-check-in-risk-transmis…
a423c08 
…sion
@mtwalli
Derive 10 minutes intervals
7e70115
@mtwalli
Merge branch 'feature/5770-check-in-risk-transmission' of https://git…
e872ac1 
…hub.com/corona-warn-app/cwa-app-android into feature/5770-check-in-risk-transmission
@mtwalli
Map location bytes as per specs
4ad0125
@mtwalli mtwalli marked this pull request as ready for review March 19, 2021 16:19
@mtwalli mtwalli requested a review from a team March 19, 2021 16:19
@d4rken d4rken self-assigned this Mar 22, 2021
d4rken
d4rken reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 👍

...App/src/test/java/de/rki/coronawarnapp/eventregistration/checkins/CheckInsTransformerTest.kt Outdated Show resolved Hide resolved
@LukasLechnerDev LukasLechnerDev self-assigned this Mar 23, 2021
d4rken
d4rken previously approved these changes Mar 23, 2021
View reviewed changes
LukasLechnerDev
LukasLechnerDev previously approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Submitted keys without noticeable side effects.

@mtwalli mtwalli dismissed stale reviews from LukasLechnerDev and d4rken via 8e2af53 March 23, 2021 10:47
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.8% 92.8% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit 46c0496 into release/2.0.x Mar 23, 2021
@mtwalli mtwalli deleted the feature/5770-check-in-risk-transmission branch March 23, 2021 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d4rken d4rken d4rken approved these changes

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

Assignees

@d4rken d4rken

@LukasLechnerDev LukasLechnerDev

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtwalli @d4rken @LukasLechnerDev @harambasicluka