Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Create Event/Location Flow (EXPOSUREAPP-5720) #2664

Merged
merged 22 commits into from
Mar 23, 2021
Merged

Create Event/Location Flow (EXPOSUREAPP-5720) #2664

merged 22 commits into from
Mar 23, 2021

Conversation

jurajkusnier
Copy link
Contributor

@jurajkusnier jurajkusnier commented Mar 22, 2021 •
edited

  • UI Implementation of Create Event/Location Flow.
  • Network request is implemented in another PR

image

Testing

  1. Test Menu > Event Registration > Start Create Event Flow

Depending on the type of the selected category (event/location) different attributes are shown on the screen

  • For categories of type "location", the following attributes can be entered
    • location (mandatory)
    • typical duration of stay (mandatory, must not be zero, default 2h)
  • For categories of type "event", the following additional attributes can be entered
    • start date, start time (mandatory)
    • end date, end time (mandatory)
    • typical duration of stay (optional, 0 treated as not set, default 0 )
    • End time must be after start time

@jurajkusnier jurajkusnier added maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Mar 22, 2021
@jurajkusnier jurajkusnier added this to the 2.0.0 milestone Mar 22, 2021
@jurajkusnier jurajkusnier marked this pull request as ready for review March 22, 2021 09:49
@jurajkusnier jurajkusnier requested a review from a team March 22, 2021 09:49
@LukasLechnerDev LukasLechnerDev self-assigned this Mar 22, 2021
@jurajkusnier jurajkusnier requested a review from a team March 22, 2021 10:24
janetback
janetback previously approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

mtwalli
mtwalli reviewed Mar 23, 2021
View reviewed changes
...arn-App/src/main/java/de/rki/coronawarnapp/ui/eventregistration/EventRegistrationUIModule.kt Show resolved Hide resolved
...va/de/rki/coronawarnapp/ui/eventregistration/organizer/create/TraceLocationCreateFragment.kt Outdated Show resolved Hide resolved
...va/de/rki/coronawarnapp/ui/eventregistration/organizer/create/TraceLocationCreateFragment.kt Outdated Show resolved Hide resolved
...a/de/rki/coronawarnapp/ui/eventregistration/organizer/create/TraceLocationCreateViewModel.kt Show resolved Hide resolved
Corona-Warn-App/src/main/res/layout/trace_location_create_fragment.xml Outdated Show resolved Hide resolved
Corona-Warn-App/src/main/res/layout/trace_location_organizer_category_fragment.xml Outdated Show resolved Hide resolved
...a/de/rki/coronawarnapp/ui/eventregistration/organizer/create/TraceLocationCreateViewModel.kt Outdated Show resolved Hide resolved
@mtwalli mtwalli self-assigned this Mar 23, 2021
@mtwalli
Copy link
Contributor

mtwalli commented Mar 23, 2021

How can I Test that can you please add some description to the PR ?

jurajkusnier and others added 4 commits March 23, 2021 10:35
@jurajkusnier
Small changes
c2748f9
@jurajkusnier
Code refactoring
766f5a4
@jurajkusnier
Merge remote-tracking branch 'origin/release/2.0.x' into feature/5720…
ae94d31 
…-create_event

# Conflicts:
#	Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml
#	Corona-Warn-App/src/main/res/values/event_registration_strings.xml
@LukasLechnerDev
Merge branch 'release/2.0.x' into feature/5720-create_event
88d25b3
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

36.5% 36.5% Coverage
0.0% 0.0% Duplication

mtwalli
mtwalli approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

janetback
janetback approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

LukasLechnerDev
LukasLechnerDev approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work! 🚀

@jurajkusnier jurajkusnier merged commit 1985b03 into release/2.0.x Mar 23, 2021
@jurajkusnier jurajkusnier deleted the feature/5720-create_event branch March 23, 2021 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

@mtwalli mtwalli mtwalli approved these changes

@janetback janetback janetback approved these changes

Assignees

@LukasLechnerDev LukasLechnerDev

@mtwalli mtwalli

Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jurajkusnier @mtwalli @LukasLechnerDev @janetback @harambasicluka