Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Adjust Plausibile Deniability for check-ins submission (EXPOSUREAPP-5707) #2676

Merged
merged 46 commits into from
Mar 30, 2021
Merged

Adjust Plausibile Deniability for check-ins submission (EXPOSUREAPP-5707) #2676

merged 46 commits into from
Mar 30, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 23, 2021 •
edited

  • Adjust plausible deniability for check-ins submission
  • Verification server padding did not change and should not change as result of this PR
  • Increased Max number of keys from 14 to 15 as per specs
  • Refactored keyPadding calculations into a new common function keyPadding that takes care of fake and genuine requests
  • New submission requestPadding is the sum of keyPadding and checkInPadding
  • Renamed some functions to reflect the latest changes ex: submitKeysToServer is now submitPayload

Testing

1- Verify the changes against the specs
2- Test against Mock server

Please note testing this PR on test environments will fail because they don't have the latest configs yet

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Mar 23, 2021
@mtwalli mtwalli added this to the 2.0.0 milestone Mar 23, 2021
@mtwalli mtwalli marked this pull request as ready for review March 23, 2021 16:42
@mtwalli mtwalli requested a review from a team March 23, 2021 16:42
@mtwalli
Log right names
4de6882
@mtwalli
Renaming
afeeb7c
@mtwalli
Fix number
9e043ab
@mtwalli
Use fold
c942601 
use fold instead of reduce to cover empty collections
@mtwalli
lint
d4f9a4c
@mtwalli
Merge branch 'release/2.0.x' into feature/5707-adjustment-plausibile-…
fed4528 
…deniability
@mtwalli
Merge branch 'release/2.0.x' into feature/5707-adjustment-plausibile-…
7ffc8f7 
…deniability
@mtwalli
Merge branch 'release/2.0.x' into feature/5707-adjustment-plausibile-…
970b6b6 
…deniability
@mtwalli
Merge branch 'release/2.0.x' into feature/5707-adjustment-plausibile-…
c80a9ff 
…deniability
@mtwalli
Merge branch 'release/2.0.x' into feature/5707-adjustment-plausibile-…
c305bc1 
…deniability
@mtwalli
Merge branch 'release/2.0.x' into feature/5707-adjustment-plausibile-…
5a3c63a 
…deniability
@mtwalli
Merge branch 'release/2.0.x' into feature/5707-adjustment-plausibile-…
d94ae18 
…deniability
@mtwalli
Merge branch 'release/2.0.x' into feature/5707-adjustment-plausibile-…
22a2659 
…deniability
d4rken
d4rken approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d4rken d4rken self-assigned this Mar 30, 2021
@chris-cwa chris-cwa self-assigned this Mar 30, 2021
chris-cwa
chris-cwa approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@chris-cwa chris-cwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.1% 76.1% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit cb0eafa into release/2.0.x Mar 30, 2021
@mtwalli mtwalli deleted the feature/5707-adjustment-plausibile-deniability branch March 30, 2021 07:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d4rken d4rken d4rken approved these changes

@chris-cwa chris-cwa chris-cwa approved these changes

Assignees

@d4rken d4rken

@chris-cwa chris-cwa

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtwalli @d4rken @chris-cwa