This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Manual checkout, Check-In navigation (EXPOSUREAPP-5410) #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
added
enhancement
mtwalli
approved these changes
Mar 24, 2021
| @@ -24,7 +25,8 @@ class ConfirmCheckInFragment : Fragment(R.layout.fragment_confirm_check_in), Aut | |||
| factoryProducer = { viewModelFactory }, | |||
| constructorCall = { factory, savedState -> | |||
| factory as ConfirmCheckInViewModel.Factory | |||
| factory.create(navArgs.verifiedTraceLocation) | |||
| val editId = if (navArgs.editCheckInId == 0L) null else navArgs.editCheckInId | |||
There was a problem hiding this comment.
should editCheckInId be nullable ? if 0 represents a nullable value
There was a problem hiding this comment.
NavArguments didn't allow primitives like long to be null, the option was greyed out.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing tap on-going and finished check-ins, you should navigate to the event confirmation/edit screen.
On-going check-ins pressing the manual check-out button should work.
You can long press the SCAN button to create test check-ins.
Deletion should also work.