-
Notifications
You must be signed in to change notification settings - Fork 499
Vertically center contact diary name and info (COMMUNITY) #2681
Vertically center contact diary name and info (COMMUNITY) #2681
Conversation
android:id="@+id/contact_diary_overview_element_attributes" | ||
android:layout_width="0dp" | ||
android:layout_height="wrap_content" | ||
android:maxLines="3" | ||
android:text="unter 15 Min, im Freien" | ||
app:layout_constraintBottom_toBottomOf="@+id/contact_diary_overview_element_image" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the fix! I suppose this bottom constraint will break the layout with multiple lines of notes, does it?
Otherwise, the PR looks good to me. Could you please target the release/2.0.x
branch instead of main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for targeting the 2.0 release branch @koenidv. Unfortunately, by simply changing the target branch, you'd end up pulling all changes from the |
Alright, I rebased the commit onto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! LGTM 🎉
Tested on a OnePlus 8 Pro (Android 11).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks!
Description
The encounter info in the contact journal isn't aligned correctly. This fixes it.