Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Event Checkin and Event Edit Fragments (EXPOSUREAPP-5743/5953) #2692

Merged
merged 40 commits into from
Mar 31, 2021

Conversation

kolyaopahle
Copy link
Contributor

Description

This PR contains the checkin and edit fragments for the event registration feature

@kolyaopahle kolyaopahle added backend Issues related to internal work not directly correlated to UI interaction ui Issue related to UI aspects maintainers Tag pull requests created by maintainers labels Mar 25, 2021
@kolyaopahle kolyaopahle added this to the 2.0.0 milestone Mar 25, 2021
@kolyaopahle kolyaopahle marked this pull request as ready for review March 26, 2021 14:18
@kolyaopahle kolyaopahle requested review from a team March 26, 2021 14:18
@mtwalli mtwalli self-assigned this Mar 26, 2021
@mtwalli
Copy link
Contributor

mtwalli commented Mar 26, 2021

1- Duration text is very close to the text
device-2021-03-26-161702

@mtwalli
Copy link
Contributor

mtwalli commented Mar 26, 2021

@mtwalli
Copy link
Contributor

mtwalli commented Mar 26, 2021

Light mode looks odd:
device-2021-03-26-162118

@chris-cwa chris-cwa self-assigned this Mar 26, 2021
@chris-cwa chris-cwa self-requested a review March 26, 2021 15:57
@ChrisLoes
Copy link

Hey @kolyaopahle,

thanks for implementing this! Is there any public documentation/information about the concept of this feature? I've only found this https://github.com/corona-warn-app/cwa-documentation/blob/master/event_registration.md#interoperability-with-other-contact-tracing-apps-draft - but it's only a draft...

thank you!

@kolyaopahle
Copy link
Contributor Author

Hi @ChrisLoes i think what you found is the most up to date publicly available information, not all parts of the specification are currently finally defined as the feature is still in active development, if you have any specific questions feel free to reach out and i will try to answer as good as i can 🙂

@ChrisLoes
Copy link

ChrisLoes commented Mar 27, 2021

@kolyaopahle thanks for your quick response.

It looks like the cwa will be able to scan qr codes also from other presence tracing apps if they implement the suggested url pattern specified in the draft.

Do you know how the encoded_signed_trace_location will be generated and how other apps like luca or corona-anmeldung.de can get or generate it?

Are there any plans?

@kolyaopahle
Copy link
Contributor Author

@ChrisLoes unfortunately this is a part of the proposal that is still receiving some changes, as of right now the idea is that the cwa backend returns these signed location upon request on the appropriate api endpoint, but there are a few changes planned as of last Friday that should develop in the coming week and (if implemented) will substantially change how event creation and checkin is handled. I'll mention you here if i have any news on the topic🙂

@mtwalli
Copy link
Contributor

mtwalli commented Mar 30, 2021

Looks nice! , just one small comment.
The duration text and the title next to it should be top aligned as per design
Screenshot 2021-03-30 at 10 49 28

mtwalli
mtwalli previously approved these changes Mar 30, 2021
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mtwalli
mtwalli previously approved these changes Mar 31, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

3.2% 3.2% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit 883bab1 into release/2.0.x Mar 31, 2021
@harambasicluka harambasicluka deleted the feature/5743-event-checkin-screen branch March 31, 2021 17:08
@ChrisLoes
Copy link

@ChrisLoes unfortunately this is a part of the proposal that is still receiving some changes, as of right now the idea is that the cwa backend returns these signed location upon request on the appropriate api endpoint, but there are a few changes planned as of last Friday that should develop in the coming week and (if implemented) will substantially change how event creation and checkin is handled. I'll mention you here if i have any news on the topic🙂

@ChrisLoes unfortunately this is a part of the proposal that is still receiving some changes, as of right now the idea is that the cwa backend returns these signed location upon request on the appropriate api endpoint, but there are a few changes planned as of last Friday that should develop in the coming week and (if implemented) will substantially change how event creation and checkin is handled. I'll mention you here if i have any news on the topic🙂

Hi @kolyaopahle ,

are there any updates/news regarding the event creation and how other presence apps can integrate it?

@mlenkeit
Copy link
Member

@ChrisLoes https://github.com/corona-warn-app/cwa-documentation/blob/master/event_registration.md is the only available description at this point. It is still labeled as draft but it is effectively representing what's currently implemented.

@ChrisLoes
Copy link

Thank you @mlenkeit ! Glad to see that there is no server connection needed anymore! Are there any release date plans or beta versions of cwa available to test the integration from other presence apps?

@ChrisLoes
Copy link

@mlenkeit Do you know how other tracing apps should set the properties for a valid CrowdNotifierData message?

message CrowdNotifierData {
uint32 version = 1;
bytes publicKey = 2; -> who's public key / how to get or generate?
bytes cryptographicSeed = 3; -> which seed?
uint32 type = 4; // exact semantic tbd
}

It would be very nice if there were some more information available how other presence-apps could generate the right data for cwa? :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants