-
Notifications
You must be signed in to change notification settings - Fork 499
Create QR Code Scan Screen (EXPOSUREAPP-5742) #2697
Create QR Code Scan Screen (EXPOSUREAPP-5742) #2697
Conversation
…an screen as of now layouts are still separate files, may condense later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small comments, what happened to the idea of having it like Google Lens
?
Corona-Warn-App/src/main/res/layout/fragment_submission_qr_code_scan.xml
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_submission_qr_code_scan.xml
Outdated
Show resolved
Hide resolved
no designs were finished as of now |
…nt_submission_qr_code_scan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the string changes in all languages except de and default.
Otherwise looks good and works as expected. 🎉
Xiamoi Mi 8 (Android 9)
… (should be overwritten by translation)
…reen' into feature/5742-eventreg-qr-code-screen
0e0cd2b
Kudos, SonarCloud Quality Gate passed! |
Description
This PR applies the current design of the qr code scan screen to the submission and event reg flow
It will also add code to validate the qr code content in the event flow in future (currently missing as qr code spec is not final)
Steps to reproduce