Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Create QR Code Scan Screen (EXPOSUREAPP-5742) #2697

Merged
merged 12 commits into from
Mar 30, 2021

Conversation

kolyaopahle
Copy link
Contributor

@kolyaopahle kolyaopahle commented Mar 26, 2021

Description

This PR applies the current design of the qr code scan screen to the submission and event reg flow
It will also add code to validate the qr code content in the event flow in future (currently missing as qr code spec is not final)

Steps to reproduce

  1. Start event registration and check if qr code scan screen works
  2. Start test registration and check if qr code scan screen works

@kolyaopahle kolyaopahle added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers labels Mar 26, 2021
@kolyaopahle kolyaopahle added this to the 2.0.0 milestone Mar 26, 2021
@kolyaopahle kolyaopahle marked this pull request as ready for review March 26, 2021 16:07
@kolyaopahle kolyaopahle requested review from a team March 26, 2021 16:07
mtwalli
mtwalli previously approved these changes Mar 29, 2021
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small comments, what happened to the idea of having it like Google Lens ?

@mtwalli mtwalli self-assigned this Mar 29, 2021
@kolyaopahle
Copy link
Contributor Author

Just two small comments, what happened to the idea of having it like Google Lens ?

no designs were finished as of now

@kolyaopahle kolyaopahle added the text change PRs with text changes. label Mar 29, 2021
mtwalli
mtwalli previously approved these changes Mar 30, 2021
janetback
janetback previously approved these changes Mar 30, 2021
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

@harambasicluka harambasicluka self-assigned this Mar 30, 2021
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the string changes in all languages except de and default.

Otherwise looks good and works as expected. 🎉
Xiamoi Mi 8 (Android 9)

@kolyaopahle kolyaopahle dismissed stale reviews from janetback and mtwalli via 88b5415 March 30, 2021 15:56
harambasicluka
harambasicluka previously approved these changes Mar 30, 2021
mtwalli
mtwalli previously approved these changes Mar 30, 2021
@kolyaopahle kolyaopahle dismissed stale reviews from mtwalli and harambasicluka via 0e0cd2b March 30, 2021 16:09
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit d8d2f5f into release/2.0.x Mar 30, 2021
@harambasicluka harambasicluka deleted the feature/5742-eventreg-qr-code-screen branch March 30, 2021 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants