Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Text changes Consent Submission Flow (EXPOSUREAPP-5415) #2704

Merged
merged 11 commits into from
Mar 30, 2021

Conversation

ralfgehrer
Copy link
Contributor

@ralfgehrer ralfgehrer commented Mar 29, 2021

How to test:
Compare the screen with Figma (link in the ticket) - except the icons. UX provided them directly.

TODO

  • Update the two blue icons
  • Update TR & EN legal strings

Screenshot_20210329-102741
Screenshot_20210329-102748
Screenshot_20210329-102758
Screenshot_20210329-102811
Screenshot_20210329-102816

@ralfgehrer ralfgehrer requested review from a team March 29, 2021 06:23
@ralfgehrer ralfgehrer marked this pull request as draft March 29, 2021 06:24
@ralfgehrer ralfgehrer changed the title Event Check-In: Text changes Consent Submission Flow (EXPOSUREAPP-5415) Text changes Consent Submission Flow (EXPOSUREAPP-5415) Mar 29, 2021
@ralfgehrer ralfgehrer added maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Mar 29, 2021
@ralfgehrer ralfgehrer added this to the 2.0.0 milestone Mar 29, 2021
<!-- YTXT: Body for consent sub section your consent subtext third point -->
<string name="submission_consent_your_consent_subsection_third_point">"Sie können Ihr Einverständnis jederzeit zurücknehmen. Die Einstellung hierfür finden Sie unter „Test anzeigen“. Vor dem Teilen werden Sie nochmal auf Ihr Einverständnis hingewiesen und um Freigabe Ihres Testergebnisses gebeten."</string>
<string name="submission_consent_your_consent_subsection_third_point">"Sie können Ihr Einverständnis jederzeit zurücknehmen. Die Einstellung hierfür finden Sie unter „Test anzeigen“. Vor dem Teilen werden Sie nochmal auf Ihr Einverständnis hingewiesen."</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: @janetback this change was not reflected in the legal text Word document - neither for DE, EN, nor TR. In Figma and the PPT file, this change was requested.
Hence, this change currently only in DE.

janetback
janetback previously approved these changes Mar 29, 2021
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

@ralfgehrer ralfgehrer marked this pull request as ready for review March 29, 2021 08:32
@ralfgehrer ralfgehrer added the prio PRs to review first. label Mar 29, 2021
@jurajkusnier jurajkusnier self-assigned this Mar 29, 2021
@chris-cwa chris-cwa self-assigned this Mar 30, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harambasicluka harambasicluka merged commit b5caf42 into release/2.0.x Mar 30, 2021
@harambasicluka harambasicluka deleted the feature/5415-text-changes branch March 30, 2021 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers prio PRs to review first. text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants