Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Camera permission card (EXPOSUREAPP-5786) #2713

Merged
merged 70 commits into from
Mar 31, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 29, 2021

  • Camera permission card in Check-Ins Screen
  • Created settings for this specifically, using system permission API did not provide away to know if the user has permanently
    denied the permission . Additionally it does not differentiate between initial permission state and after user denial.
  • Refactored CheckInsViewModel and CheckInFragment logic into smaller code chunks

Testing

  • Run the App and play with the permissions , Card should be only visible incase user has denied the permission permanently.
  • Test from Submission Flow and from Check-In flow where Camera permission is requested

TODO

  • Add some tests

d4rken
d4rken previously approved these changes Mar 31, 2021
@chiljamgossow chiljamgossow self-assigned this Mar 31, 2021
chiljamgossow
chiljamgossow previously approved these changes Mar 31, 2021
@mtwalli mtwalli dismissed stale reviews from chiljamgossow and d4rken via 557fa9b March 31, 2021 12:37
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

30.8% 30.8% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

@mtwalli mtwalli merged commit 932b714 into release/2.0.x Mar 31, 2021
@mtwalli mtwalli deleted the feature/5786-camera-permission-card branch March 31, 2021 13:36
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants