This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Risk state (EXPOSUREAPP-5697) #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/checkins/CheckIn.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/checkins/download/CheckInsPackage.kt
# Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/eventregistration/ui/EventRegistrationTestFragmentViewModel.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/checkins/riskcalculation/PresenceTracingRiskCalculator.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/checkins/riskcalculation/PresenceTracingRiskMapper.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/eventregistration/checkins/riskcalculation/PresenceTracingRiskCalculatorTest.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/eventregistration/checkins/riskcalculation/PresenceTracingRiskMapperTest.kt
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/checkins/CheckIn.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/checkins/CheckInRepository.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/eventregistration/checkins/CheckInRepositoryTest.kt
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/checkins/riskcalculation/Matching.kt
BMItr
reviewed
Apr 1, 2021
...App/src/main/java/de/rki/coronawarnapp/presencetracing/risk/PresenceTracingRiskRepository.kt
Outdated
Show resolved
Hide resolved
BMItr
previously approved these changes
Apr 1, 2021
chiljamgossow
force-pushed
the
feature/5697-risk-state
branch
from
96d30aa
to
edd3e31
Compare
BMItr
previously approved these changes
Apr 1, 2021
jurajkusnier
reviewed
Apr 1, 2021
| val endTime = timeStamper.nowUTC.minus(Days.days(15).toStandardDuration()) | ||
| traceTimeIntervalMatchDao.deleteOlderThan(endTime.millis) | ||
| internal suspend fun markPackageProcessed(warningPackageId: String) { | ||
| // TODO |
There was a problem hiding this comment.
when/where this will be implemented?
# Conflicts: # Corona-Warn-App/schemas/de.rki.coronawarnapp.eventregistration.storage.TraceLocationDatabase/1.json
|
Kudos, SonarCloud Quality Gate passed! |
jurajkusnier
approved these changes
Apr 1, 2021
|
I was thinking about error notifications, if either EW calculations or PT calculations for any reason (and there are some...) permanently fail in the future... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes are renaming only in order to differentiate between the risk results.
There are now two sets of risk results, one for exposure windows (ew) and one for presence tracing (pt). They are all available in the RiskLevelStorage interface.
The risk calculation for ew remains untouched. It is still the basis for all analytics and survey logic.
The two sets are combined to CombinedEwPtRisk, to be used for the home tracing card and details.
Changes in this combined risk should trigger the risk level change notification (see RiskLevelChangeDetector).
The home card will always show the highest risk that was calculated, that means if there is one high risk check-in or encounter, it will turn red. Calculation failed will only show if both calculations failed.
How to test: check whether the old risk calculation with exposure windows still works as before
Once the warning downloads are available, the risk from check-ins should also show up.
Missing: all unit tests -> follow up PR