This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Add warning deletion screen for Antigen and PCR (EXPOSUREAPP-6032) #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelherbstreith
added
ui
SamuraiKek
previously approved these changes
Apr 9, 2021
AlexanderAlferov
suggested changes
Apr 9, 2021
Corona-Warn-App/src/main/res/layout/fragment_submission_deletion_warning.xml
Outdated
Show resolved
Hide resolved
...java/de/rki/coronawarnapp/ui/submission/deletionwarning/SubmissionDeletionWarningFragment.kt
Outdated
Show resolved
Hide resolved
SabineLoss
reviewed
Apr 9, 2021
| <!-- YTXT: Body for rapid test submission deletion warning --> | ||
| <string name="submission_deletion_warning_body_antigen_test">"Sie haben bereits einen Schnelltest erfasst. Die App kann maximal einen Schnelltest und einen PCR-Test gleichzeitig verwalten. Wenn Sie einen weiteren Schnelltest erfassen, wird der erste Schnelltest aus der App gelöscht."</string> | ||
| <!-- YTXT: Headline for PCR test submission deletion warning --> | ||
| <string name="submission_deletion_warning_headline_pcr_test">"Sie haben bereits einen PCR-Test registriert."</string> |
AlexanderAlferov
previously approved these changes
Apr 9, 2021
SamuraiKek
previously approved these changes
Apr 9, 2021
|
Hi @axelherbstreith, @SabineLoss @vaubaehn, although @vaubaehn 's distinction is correct, this is a very technical distinction which I believe does not need to be made on the UI itself. @SabineLoss , you are right, we should stay consistent here. In most instances we have used 'registered', which is why I suggest changing to 'registrieren' in this case too. |
axelherbstreith
dismissed stale reviews from SamuraiKek and AlexanderAlferov
via
322c079
AlexanderAlferov
approved these changes
Apr 12, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only added the new screen. Connection to the submission flow will be done in a separate PR.