This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Extract data from QR codes (EXPOSUREAPP-6031) #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chiljamgossow and @LukasLechnerDev |
No, they are encoded with base64/base64url. |
|
Have to add the tech spec changes affecting guids |
...Warn-App/src/main/java/de/rki/coronawarnapp/coronatest/qrcode/RapidAntigenQrCodeExtractor.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/de/rki/coronawarnapp/ui/submission/qrcode/scan/SubmissionQRCodeScanViewModel.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/coronatest/qrcode/CoronaTestQRCode.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/qrcode/scan/SubmissionQRCodeScanViewModel.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/ui/submission/qrcode/scan/SubmissionQRCodeScanViewModelTest.kt
d4rken
reviewed
Apr 19, 2021
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/coronatest/qrcode/CoronaTestQRCode.kt
Outdated
Show resolved
Hide resolved
...a-Warn-App/src/main/java/de/rki/coronawarnapp/coronatest/qrcode/CoronaTestQRCodeValidator.kt
Outdated
Show resolved
Hide resolved
...a-Warn-App/src/main/java/de/rki/coronawarnapp/coronatest/qrcode/CoronaTestQRCodeValidator.kt
Outdated
Show resolved
Hide resolved
chiljamgossow
force-pushed
the
feature/6031-extract-data
branch
from
17c14ca
to
a6a8cb4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
d4rken
approved these changes
Apr 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts data from valid pcr and rapid antigen qr codes and returns the corresponding object
Includes changes to RAT qr code format https://github.com/corona-warn-app/cwa-app-tech-spec/pull/37/commits/1ba31322e0df8925d132b26d57c599d054b9a561 including double hashing for registration
How to test:
Scan a QR code with the new format https://github.com/corona-warn-app/cwa-app-tech-spec/pull/37/commits/27944cd986a2bb379d3ebe10bf348dd69c03a1c5