Replace spacing near scroll views with overscroll (COMMUNTIY) #2884

fynngodau · 2021-04-21T06:44:36Z

As previously discussed in #1882 (comment), this PR removes white space near scroll views, mostly at the bottom, and instead adds that space inside the scroll view (so it scrolls with the content). This makes the app feel a lot better.

Here you can see some examples:

Before	After

These views have been fixed that way:

App Information
About the App
Data Privacy
Legal Notices
Technical Hotline
Statistics explanation
Edit Places
Edit People
Settings
Notifications
Prioritized Background Activity
Share Data
Check In (onboarding / information)

The error report screen has also been fixed to remove the white space between the elevated, sticky content and the scrollable content. Note that here, I changed the total bottom padding of the scrollable content from 20dp to 24dp for consistency within the layout.

Additionally, I fixed the button in the check in layout to have the same margin to top and bottom as the Open Journal button in the Contact Journal onboarding / information screen.

Internal Tracking ID: EXPOSUREAPP-6605

Note that this changes the total padding of the content in the debuglog fragment from 20dp to 24dp for consistency within the layout.

dsarkar · 2021-04-21T07:00:38Z

@fynngodau Thanks. Internal Tracking ID: EXPOSUREAPP-6605

Corona-Warn-App Open Source Team

fynngodau · 2021-04-24T11:53:51Z

I added fixes for the following layouts, which I initially overlooked:

Settings
Notifications (notification settings)
Prioritized Background Activity (battery optimization settings)
Share Data (ppa settings)
Detailed Information about Data Sharing

This partially reverts commit 85e4650 to avoid conflicts with corona-warn-app#2945.

fynngodau · 2021-04-24T13:04:06Z

I undid the change to the Detailed Information about Data Sharing screen to avoid conflict with #2945.

Also changes margin of button to match that of contact journal onboarding

fynngodau · 2021-04-25T10:29:18Z

One more screen:

Check In onbaording

Also fixes the margin of the Check In onboarding Agree button to match that of the Open Journal button in the Contact Journal onboarding.

harambasicluka

Overall looks pretty good, but I would like to take this chance to align all bottom paddings :)

What do you think?

harambasicluka · 2021-04-26T12:12:33Z

Corona-Warn-App/src/main/res/layout/fragment_information_about.xml

@@ -24,7 +24,10 @@
            android:layout_width="0dp"
            android:layout_height="0dp"
            android:fillViewport="true"
-            app:layout_constraintBottom_toBottomOf="@+id/guideline_bottom"
+            android:paddingBottom="@dimen/spacing_small"


I would align the bottom padding on this kind of fragments, I would go with @dimen/spacing_normal as it is here: https://github.com/corona-warn-app/cwa-app-android/pull/2884/files#diff-99108bde996a7dd32ce38fb5594a027efd59819f2b88d116dcc7b8f3eaced7ebR30

harambasicluka · 2021-04-26T12:13:08Z

Corona-Warn-App/src/main/res/layout/fragment_information_contact.xml

@@ -24,7 +24,10 @@
            android:layout_width="0dp"
            android:layout_height="0dp"
            android:fillViewport="true"
-            app:layout_constraintBottom_toBottomOf="@+id/guideline_bottom"
+            android:paddingBottom="@dimen/spacing_small"


Same as above.

harambasicluka · 2021-04-26T12:13:17Z

Corona-Warn-App/src/main/res/layout/fragment_information_legal.xml

            android:focusable="true"
-            app:layout_constraintBottom_toBottomOf="@+id/guideline_bottom"
+            android:paddingBottom="@dimen/spacing_small"


Same as above.

harambasicluka · 2021-04-26T12:13:32Z

Corona-Warn-App/src/main/res/layout/fragment_information_privacy.xml

@@ -30,7 +30,9 @@
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:fillViewport="true"
-            android:paddingBottom="@dimen/guideline_bottom">
+            android:paddingBottom="@dimen/guideline_bottom"


Same as above.

harambasicluka · 2021-04-26T12:13:42Z

Corona-Warn-App/src/main/res/layout/fragment_information_technical.xml

@@ -30,7 +30,9 @@
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:fillViewport="true"
-            android:paddingBottom="@dimen/guideline_bottom">
+            android:paddingBottom="@dimen/guideline_bottom"


Same as above.

harambasicluka · 2021-04-26T12:14:24Z

Corona-Warn-App/src/main/res/layout/fragment_settings_background_priority.xml

@@ -31,7 +31,10 @@
            android:layout_width="0dp"
            android:layout_height="0dp"
            android:fillViewport="true"
-            app:layout_constraintBottom_toBottomOf="@+id/guideline_bottom"
+            android:paddingBottom="@dimen/spacing_small"


Same as above.

harambasicluka · 2021-04-26T12:14:32Z

Corona-Warn-App/src/main/res/layout/fragment_settings_notifications.xml

@@ -32,7 +32,10 @@
            android:layout_width="0dp"
            android:layout_height="0dp"
            android:fillViewport="true"
-            app:layout_constraintBottom_toBottomOf="@+id/guideline_bottom"
+            android:paddingBottom="@dimen/spacing_small"


Same as above.

harambasicluka · 2021-04-26T12:14:41Z

Corona-Warn-App/src/main/res/layout/fragment_settings_privacy_preserving_analytics.xml

@@ -27,7 +27,10 @@
            android:id="@+id/scrollview"
            android:layout_width="0dp"
            android:layout_height="0dp"
-            app:layout_constraintBottom_toTopOf="@+id/guideline_bottom"
+            android:paddingBottom="@dimen/spacing_small"


Same as above.

harambasicluka · 2021-04-26T12:21:04Z

Corona-Warn-App/src/main/res/layout/fragment_statistics_explanation.xml

@@ -93,7 +93,10 @@
        <ScrollView
            android:layout_width="0dp"
            android:layout_height="0dp"
-            app:layout_constraintBottom_toBottomOf="@id/guideline_bottom"
+            android:paddingBottom="@dimen/spacing_small"


Same as above. But there seems to be already more space.

The answer is here:

cwa-app-android/Corona-Warn-App/src/main/res/layout/fragment_statistics_explanation.xml

Line 431 in e1ec946

android:layout_marginBottom="23dp"

That's an odd margin… we should remove that before increasing the scroll view's padding.

harambasicluka · 2021-04-26T12:21:44Z

Corona-Warn-App/src/main/res/layout/fragment_trace_location_onboarding.xml

@@ -31,7 +32,9 @@
        android:id="@+id/check_in_onboarding_scroll_view"
        android:layout_width="match_parent"
        android:layout_height="0dp"
-        android:layout_marginBottom="20dp"
+        android:paddingBottom="@dimen/spacing_small"


Seems fine, as the floating button is below.

fynngodau · 2021-04-26T13:11:53Z

@harambasicluka Agreed – I have pushed a change updating all the places you pointed out.

chiljamgossow

Very nice! Thanks for fixing.

fynngodau added 4 commits April 21, 2021 08:11

Remove space below scrollers and add overscroll in app info screens

7df6ab3

Note that this changes the total padding of the content in the debuglog fragment from 20dp to 24dp for consistency within the layout.

Remove spacing below scroll view and add overscroll to stats explanation

9120b82

Fix scrollbars

0a1e95a

Fix contact diary (edit places & locations) scroll behavior

185428e

fynngodau requested a review from a team April 21, 2021 06:44

dsarkar added the community Tag issues created by community members label Apr 21, 2021

dsarkar assigned maugst Apr 21, 2021

dsarkar added the mirrored-to-jira This item is also tracked internally in JIRA label Apr 21, 2021

Merge branch 'release/2.1.x' into fix/overscroll

f88ec4c

harambasicluka assigned harambasicluka and unassigned maugst Apr 21, 2021

dsarkar added the Fix 2.1 Fix is planned for 2.1 label Apr 21, 2021

harambasicluka and others added 2 commits April 21, 2021 18:54

Merge branch 'release/2.1.x' into fix/overscroll

c68b7a3

Remove space below scrollers and add overscroll in settings screens

85e4650

Undo changes to PPA more info fragment

dfaa941

This partially reverts commit 85e4650 to avoid conflicts with corona-warn-app#2945.

Fix Check In onboarding

cc4542b

Also changes margin of button to match that of contact journal onboarding

harambasicluka added 2 commits April 26, 2021 12:15

Merge branch 'release/2.1.x' into fix/overscroll

81fd660

Merge branch 'release/2.1.x' into fix/overscroll

e426c85

harambasicluka suggested changes Apr 26, 2021

View reviewed changes

Uniform bottom paddings

155e531

d4rken added this to the 2.1.0 milestone Apr 27, 2021

chiljamgossow self-assigned this Apr 27, 2021

chiljamgossow reviewed Apr 27, 2021

View reviewed changes

harambasicluka added 2 commits April 28, 2021 17:58

Merge branch 'release/2.1.x' into fix/overscroll

8b956a1

Merge branch 'release/2.1.x' into fix/overscroll

125df5c

harambasicluka approved these changes Apr 28, 2021

View reviewed changes

d4rken merged commit 7732282 into corona-warn-app:release/2.1.x Apr 28, 2021

vaubaehn mentioned this pull request May 3, 2021

App Information cut off at bottom on small screen (2) #3059

Closed

3 tasks

fynngodau deleted the fix/overscroll branch May 3, 2021 20:48

fynngodau mentioned this pull request Jul 13, 2021

Add missing clipToPadding in App Information screen (COMMUNITY) #3707

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace spacing near scroll views with overscroll (COMMUNTIY) #2884

Replace spacing near scroll views with overscroll (COMMUNTIY) #2884

fynngodau commented Apr 21, 2021 •

edited

dsarkar commented Apr 21, 2021

fynngodau commented Apr 24, 2021

fynngodau commented Apr 24, 2021

fynngodau commented Apr 25, 2021

harambasicluka left a comment

harambasicluka Apr 26, 2021

harambasicluka Apr 26, 2021

harambasicluka Apr 26, 2021

harambasicluka Apr 26, 2021

harambasicluka Apr 26, 2021

harambasicluka Apr 26, 2021

harambasicluka Apr 26, 2021

harambasicluka Apr 26, 2021

harambasicluka Apr 26, 2021

fynngodau Apr 26, 2021

harambasicluka Apr 26, 2021

fynngodau commented Apr 26, 2021

chiljamgossow left a comment

Replace spacing near scroll views with overscroll (COMMUNTIY) #2884

Replace spacing near scroll views with overscroll (COMMUNTIY) #2884

Conversation

fynngodau commented Apr 21, 2021 • edited

dsarkar commented Apr 21, 2021

fynngodau commented Apr 24, 2021

fynngodau commented Apr 24, 2021

fynngodau commented Apr 25, 2021

harambasicluka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fynngodau commented Apr 26, 2021

chiljamgossow left a comment

Choose a reason for hiding this comment

fynngodau commented Apr 21, 2021 •

edited