Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add transition to Contact Journal onboarding fragment (COMMUNITY) #2954

Merged

Conversation

fynngodau
Copy link
Contributor

@fynngodau fynngodau commented Apr 25, 2021

This PR fixes #2952 and increases consistency between the two screens by adding a transition to the Contact Journal onboarding fragment.

Video demonstration:

info-transition-fixed.mp4

Internal Tracking-ID: EXPOSUREAPP-6763

This makes the transition behavior of this fragment the same as the check-in
onboarding fragment.
@fynngodau fynngodau requested a review from a team April 25, 2021 08:09
@harambasicluka harambasicluka added the community Tag issues created by community members label Apr 26, 2021
@mtwalli mtwalli self-assigned this Apr 26, 2021
@mtwalli
Copy link
Contributor

mtwalli commented Apr 26, 2021

@fynngodau Thank you! for adding the transition. We have to make one more adjustment to have it consistent with the Check-Ins.

1- in contact_diary_overview_fragment.xml please set background colour as android:background="@color/colorBackground"

2- in ContactDiaryOverviewFragment please add

 override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        exitTransition = MaterialSharedAxis(MaterialSharedAxis.Z, true)
        reenterTransition = MaterialSharedAxis(MaterialSharedAxis.Z, false)
    }

So we will have the consistent transitions when the information screen is also accessed from overflow menu as in

device-2021-04-26-124157.mp4

@axelherbstreith axelherbstreith self-assigned this Apr 26, 2021
@d4rken d4rken added this to the 2.1.0 milestone Apr 27, 2021
@heinezen heinezen added the mirrored-to-jira This item is also tracked internally in JIRA label Apr 27, 2021
@fynngodau
Copy link
Contributor Author

@mtwalli Great find! Added to PR.

Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@axelherbstreith axelherbstreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@harambasicluka harambasicluka merged commit ba2d4b7 into corona-warn-app:release/2.1.x Apr 28, 2021
@fynngodau fynngodau deleted the fix/diary-onboarding branch May 1, 2021 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Tag issues created by community members mirrored-to-jira This item is also tracked internally in JIRA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants