This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Add transition to Contact Journal onboarding fragment (COMMUNITY) #2954
Merged
harambasicluka
merged 5 commits into
corona-warn-app:release/2.1.x
from
fynngodau:fix/diary-onboarding
Apr 28, 2021
Merged
Add transition to Contact Journal onboarding fragment (COMMUNITY) #2954
harambasicluka
merged 5 commits into
corona-warn-app:release/2.1.x
from
fynngodau:fix/diary-onboarding
Apr 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the transition behavior of this fragment the same as the check-in onboarding fragment.
@fynngodau Thank you! for adding the transition. We have to make one more adjustment to have it consistent with the Check-Ins. 1- in 2- in override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
exitTransition = MaterialSharedAxis(MaterialSharedAxis.Z, true)
reenterTransition = MaterialSharedAxis(MaterialSharedAxis.Z, false)
} So we will have the consistent transitions when the information screen is also accessed from overflow menu as in device-2021-04-26-124157.mp4 |
@mtwalli Great find! Added to PR. |
mtwalli
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
axelherbstreith
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
community
Tag issues created by community members
mirrored-to-jira
This item is also tracked internally in JIRA
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2952 and increases consistency between the two screens by adding a transition to the Contact Journal onboarding fragment.
Video demonstration:
info-transition-fixed.mp4
Internal Tracking-ID: EXPOSUREAPP-6763