This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Adjust deadman notification scheduler (EXPOSUREAPP-6600) #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajkusnier
previously approved these changes
Apr 28, 2021
d4rken
reviewed
Apr 28, 2021
| coronaTestRepository.coronaTests, | ||
| enfClient.isTracingEnabled | ||
| ) { isOnboarded, coronaTests, isTracingEnabled -> | ||
| val noPositiveTestRegistered = coronaTests.none { it.isSubmissionAllowed } |
There was a problem hiding this comment.
Should we use isPositive? Because isSubmissionAllowed will be false again after submission.
override val isSubmissionAllowed: Boolean
get() = isPositive && !isSubmittedThere was a problem hiding this comment.
Good point. Thanks! Changed it to use isPositive now.
LukasLechnerDev
dismissed stale reviews from BMItr and jurajkusnier
via
2302ba8
|
Kudos, SonarCloud Quality Gate passed! |
jurajkusnier
approved these changes
Apr 28, 2021
d4rken
approved these changes
Apr 28, 2021
harambasicluka
deleted the
feature/6600-Review-DeadmanNotificationScheduler
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the Deadman Notification scheduler to our new way of how workers work. This way, we don't schedule work from several places within the app, but only from
DeadmanNotificationSchedulerBasically,
deadmanNotificationScheduler.setup()is called at app start and then the scheduler observes if=> We schedule the Deadman Notification if onBoarding was done, enf tracing is activated and no positive test result is registered.
=> I didn't change the worker itself, so it should behave as before.