This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix crash when the UI queues multiple test removals while a slow network request is on-going (DEV) #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have a blocking operations (network refresh), the UI could queue up multiple test removals. The first one would work, the following would throw an exception. We should handle this silently for users of `SubmissionRepository`
d4rken
added
bug
d4rken
changed the title
chris-cwa
approved these changes
Apr 28, 2021
axelherbstreith
approved these changes
Apr 28, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For data consistency, the test repo processes actions sequentially.
If we have a blocking operations (network refresh), the UI could queue up multiple test removals.
The first one would work, the following would throw an exception.
We should handle this silently for users of
SubmissionRepository.