This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix crashing PCR test result update worker (DEV) #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
added
bug
|
Kudos, SonarCloud Quality Gate passed! |
AlexanderAlferov
approved these changes
Apr 29, 2021
axelherbstreith
approved these changes
Apr 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filtering for
coronaTestRepo.refresh(...)did not work and the updated results contained all registered tests.The worker which used
.single()(because there should only be one PCR test) threw an exception after the update.This caused it to retry despite success and may lead to inconsistent test result behavior.
Other callers of
refresh()may also have experienced issues.Conditions: