This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…288) * settings icon tracing resized, missing grey color added * fixed dark mode / light mode illustrations * fixed small issue in strings * OnBoardingTracingFragment: catch exceptions also for asyncIsEnabled() (#282) Executing `InternalExposureNotificationClient.asyncIsEnabled()` may also result in an exception of `com.google.android.gms.common.api.ApiException` if connection to GMS isn't possible. Not catching this exception results in fatal crash. ``` 2020-06-08 16:33:29.693 20904-20904/de.rki.coronawarnapp E/AndroidRuntime: FATAL EXCEPTION: main Process: de.rki.coronawarnapp, PID: 20904 com.google.android.gms.common.api.ApiException: 17: API: Nearby.EXPOSURE_NOTIFICATION_API is not available on this device. Connection failed with: ConnectionResult{statusCode=UNKNOWN_ERROR_CODE(39507), resolution=null, message=null} at com.google.android.gms.common.internal.ApiExceptionUtil.fromStatus(com.google.android.gms:play-services-base@@17.3.0:4) at com.google.android.gms.common.api.internal.ApiExceptionMapper.getException(com.google.android.gms:play-services-base@@17.3.0:2) at com.google.android.gms.common.api.internal.zah.zaa(com.google.android.gms:play-services-base@@17.3.0:18) at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.zaa(com.google.android.gms:play-services-base@@17.3.0:211) at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.zaa(com.google.android.gms:play-services-base@@17.3.0:217) at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.zaa(com.google.android.gms:play-services-base@@17.3.0:115) at com.google.android.gms.common.api.internal.GoogleApiManager$zaa.onConnectionFailed(com.google.android.gms:play-services-base@@17.3.0:79) at com.google.android.gms.common.internal.zag.onConnectionFailed(com.google.android.gms:play-services-base@@17.3.0:2) at com.google.android.gms.common.internal.BaseGmsClient$zzf.zza(com.google.android.gms:play-services-basement@@17.3.0:6) at com.google.android.gms.common.internal.BaseGmsClient$zza.zza(com.google.android.gms:play-services-basement@@17.3.0:25) at com.google.android.gms.common.internal.BaseGmsClient$zzc.zzc(com.google.android.gms:play-services-basement@@17.3.0:11) at com.google.android.gms.common.internal.BaseGmsClient$zzb.handleMessage(com.google.android.gms:play-services-basement@@17.3.0:49) at android.os.Handler.dispatchMessage(Handler.java:106) at com.google.android.gms.internal.common.zzi.dispatchMessage(com.google.android.gms:play-services-basement@@17.3.0:8) at android.os.Looper.loop(Looper.java:223) at android.os.HandlerThread.run(HandlerThread.java:67) ``` Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: marcmuschko <marc.muschko@sap.com> * build fixes in tests Co-authored-by: lenke182 <jan_lenke@freenet.de> Co-authored-by: Jakob Möller <jakob.moeller@sap.com>
* General Pinning Signed-off-by: d067928 <jakob.moeller@sap.com> * remove todo Signed-off-by: d067928 <jakob.moeller@sap.com>
* accessibility button texts * accessibility fixes * replace buttons with image views * solve conflicts with dev * accessibility for all onboarding views * accessibility for all submission views * accessibility for risk details * call views with bindings * pull request review fixes * strings * lint check fixes * lint check fixes * accessibility for settings and information views * lint check fixes Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by: Luka Harambasic <luka.harambasic@sap.com>
* fixes repository refresh of successful last risk level calculation after app reset * adaptive launch icons * Revert "adaptive launch icons" This reverts commit 5f8d9bc. * default dialog button text color added * small fixes, todos removed when applicable * fixed phone number string * added link to exposure settings from app reset * resolved build issue
* reintroduced our old headers everywhere :) * fixed onboarding header icon alignment * removed empty row on risk details bottom * removed unused formatter * introduced stable dividers for risk card * risk identification is not possible: primary icon color to neutral * adapted circle sizing and alignment * circleColor: added stable Color * icon alignments: top right * fixed spacings * changed light header logo * moved row * larger header logos * ktlintformat
Co-authored-by: Jakob Möller <jakob.moeller@sap.com>
* add unit tests for FormatterSubmissionHelper from util/formatter * FormatterSubmissionHelperTest.kt unit tests done * Actualised with dev Co-authored-by: Hee Tatt Ooi <hee.tatt.ooi@sap.com>
Signed-off-by: d067928 <jakob.moeller@sap.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.