This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Adjust test polling behavior 21 days after registration (EXPOSUREAPP-6882) #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata set). Stop test polling after 21 days if we are in a final state (*_REDEEMED).
d4rken
added
bug
BMItr
reviewed
Apr 29, 2021
| import org.joda.time.Instant | ||
|
|
||
| fun CoronaTest.isOlderThan21Days(nowUTC: Instant): Boolean { | ||
| return Duration(registeredAt, nowUTC).standardDays > 21 |
There was a problem hiding this comment.
Personal preference, but i would use a default param here
BMItr
suggested changes
Apr 29, 2021
|
Kudos, SonarCloud Quality Gate passed! |
chiljamgossow
approved these changes
Apr 30, 2021
mlenkeit
approved these changes
Apr 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map HTTP 400 errors to *_REDEEMED after 21 days (server has deleted data set).
Stop test polling after 21 days if we are in a final state (*_REDEEMED).
See ticket and related tech spec changes. 2.1.x hotfix target.
Check test cases, right PCR/RAT results?
Testable via mockserver and timetravel