Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix RAT Strings (EXPOSUREAPP-6942) #3029

Merged
merged 8 commits into from Apr 30, 2021

Conversation

axelherbstreith
Copy link
Contributor

Update RAT Strings

image
image
image
image

@axelherbstreith axelherbstreith added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Apr 30, 2021
@axelherbstreith axelherbstreith added this to the 2.1.2 milestone Apr 30, 2021
@axelherbstreith axelherbstreith requested review from a team April 30, 2021 13:22
SabineLoss
SabineLoss previously approved these changes Apr 30, 2021
@chris-cwa chris-cwa self-assigned this Apr 30, 2021
Copy link
Contributor

@vaubaehn vaubaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comprehensibility in one point - and "gender speech"

<!-- YTXT: Body for keys submission no consent text first part-->
<string name="submission_no_consent_your_consent_subsection_body_first_part">"Durch Antippen von „Einverstanden“ willigen Sie wie folgt ein:"</string>
<!-- YTXT: Body for keys submission no consent text second part-->
<string name="submission_no_consent_your_consent_subsection_body_second_part">"<b>Die App teilt Ihr Testergebnis, um Nutzer von offiziellen Corona-Apps, denen Sie begegnet sind, zu warnen. Die Warnung funktioniert in den oben genannten Ländern. Wenn Sie zusätzlich Angaben zum Beginn Ihrer Symptome machen, werden auch diese geteilt.</b> Bitte geben Sie Ihr Testergebnis (genauer gesagt: Ihre Zufalls-IDs der letzten 14 Tage) im nächsten Schritt frei, indem Sie „Teilen“ antippen."</string>
<string name="submission_no_consent_your_consent_subsection_body_second_part">"<b>Die App teilt Ihr Testergebnis, um Nutzer, denen Sie begegnet sind, zu warnen. Dies betrifft Nutzer von Corona-Apps der oben genannten Länder und Nutzer, die zeitgleich am selben Event oder Ort wie Sie eingecheckt waren. Im Falle von Schnelltests werden nur Nutzer der Corona-Warn-App gewarnt. Wenn Sie zusätzlich Angaben zum Beginn Ihrer Symptome machen, werden auch diese Daten geteilt.</b>"</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a while to understand

Dies betrifft Nutzer von Corona-Apps der oben genannten Länder und Nutzer, die zeitgleich am selben Event oder Ort wie Sie eingecheckt waren.

that these are two separate conditions. In the first readings I understood that users of foreign contries who were also checked in with event registration will be warned.

I'd suggest to make two sentences out of it, or add "...und außerdem":
"Dies betrifft Nutzer von Corona-Apps der oben genannten Länder und außerdem Nutzer, die zeitgleich am selben Event oder Ort wie Sie eingecheckt waren."

Also I stumbled now upon missing "gendering" -> Nutzer:innen etc... I don't know what are your plans for this issue, but I guess all German documents/strings would need to be inspected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your feedback. I'll forward both suggestions to our User Assistent colleagues. Won't be changed in this PR as these text are set since a while.

@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@SabineLoss SabineLoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA Approved

Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@axelherbstreith axelherbstreith assigned BMItr and unassigned chris-cwa Apr 30, 2021
@harambasicluka harambasicluka merged commit c4ed2be into release/2.1.x Apr 30, 2021
@harambasicluka harambasicluka deleted the fix/6942-rat-strings-not-updated branch April 30, 2021 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants