Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Remove fitsSystemWindows from fragments (EXPOSUREAPP-7366,EXPOSUREAPP-7368) #3233

Merged
merged 2 commits into from
May 20, 2021
Merged

Remove fitsSystemWindows from fragments (EXPOSUREAPP-7366,EXPOSUREAPP-7368) #3233

merged 2 commits into from
May 20, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented May 20, 2021 •
edited

  • Remove fitsSystemWindows from fragments, it is causing some overlay when keyboard is open
  • this is flag is set now in the main activity layout and it should apply to all hosted fragments
  • One screen should have been fixed by @chiljamgossow before , but it seems it is lost somehow

@mtwalli mtwalli added bug Something isn't working maintainers Tag pull requests created by maintainers labels May 20, 2021
@mtwalli mtwalli added this to the 2.3.0 milestone May 20, 2021
@mtwalli mtwalli requested a review from a team May 20, 2021 07:13
@mtwalli mtwalli added the prio PRs to review first. label May 20, 2021
@SamuraiKek SamuraiKek self-assigned this May 20, 2021
SamuraiKek
SamuraiKek approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@axelherbstreith axelherbstreith self-assigned this May 20, 2021
@dsarkar dsarkar mentioned this pull request May 20, 2021
Closed
3 tasks
@dsarkar
Copy link
Member

dsarkar commented May 20, 2021

Fixes #3216

@sonarcloud
Copy link

sonarcloud bot commented May 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mtwalli mtwalli merged commit fb67a95 into release/2.3.x May 20, 2021
@mtwalli mtwalli deleted the fix/7366-hidden-layout-keyboard branch May 20, 2021 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuraiKek SamuraiKek SamuraiKek approved these changes

@axelherbstreith axelherbstreith axelherbstreith approved these changes

Assignees

@SamuraiKek SamuraiKek

@axelherbstreith axelherbstreith

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtwalli @dsarkar @SamuraiKek @axelherbstreith