Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Contact Journal Extension - Store RAT and PCR Tests results (EXPOSUREAPP-6041) #3238

Merged
merged 15 commits into from
May 25, 2021
Merged

Contact Journal Extension - Store RAT and PCR Tests results (EXPOSUREAPP-6041) #3238

merged 15 commits into from
May 25, 2021

Conversation

jurajkusnier
Copy link
Contributor

  • Test result is added to a new database and later will be displayed in the contact journal

Testing

  • Scan PCR/RAT test
  • See test results
  • If the test is positive or negative new record should be added to DB
  • Check Test Menu > Corona Tests > Contact diary tests if the test is there

@jurajkusnier jurajkusnier added the maintainers Tag pull requests created by maintainers label May 20, 2021
@jurajkusnier jurajkusnier added this to the 2.4.0 milestone May 20, 2021
@jurajkusnier jurajkusnier requested a review from a team May 20, 2021 14:04
@BMItr BMItr self-assigned this May 20, 2021
@BMItr
Copy link
Contributor

BMItr commented May 20, 2021

@jurajkusnier
Looking good overall 👌
I would consider not to create a new DB for the TestResults, because the ContactJournal already has an own DB.
Just create a new Table for your needs..

@jurajkusnier
Merge branch 'release/2.4.x' into feature/6008-store_test_result_to_c…
c1a9d46 
…ontact_journal

# Conflicts:
#	Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/coronatest/ui/CoronaTestTestFragment.kt
#	Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/DataResetTest.kt
@jurajkusnier
Move TestJournal Table to ContactDiaryDatabase
b37f495
@jurajkusnier
remove unused files
018de1a
@jurajkusnier
Copy link
Contributor Author

@jurajkusnier
Looking good overall 👌
I would consider not to create a new DB for the TestResults, because the ContactJournal already has an own DB.
Just create a new Table for your needs..

Thanks, yes, it makes a perfect sense. I've updated the code

@mtwalli mtwalli self-assigned this May 21, 2021
@BMItr
Copy link
Contributor

BMItr commented May 21, 2021

@jurajkusnier thx for the adjustments.
Please consider at last to add some tests for migration & table and/or adjust the "ContactDiaryDataBaseMigrationTest" & "ContactDiaryDatabaseTest".
Also testing the converter would make some sense (but low prio. optional)

mtwalli
mtwalli previously approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ,please consider Bernd points ?

@jurajkusnier jurajkusnier requested a review from mtwalli May 21, 2021 14:27
@sonarcloud
Copy link

sonarcloud bot commented May 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

2.1% 2.1% Coverage
0.0% 0.0% Duplication

@jurajkusnier jurajkusnier mentioned this pull request May 21, 2021
Merged
@dsarkar dsarkar mentioned this pull request May 22, 2021
Open
mtwalli
mtwalli approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

BMItr
BMItr approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the final adjustments.
lgtm! 👌

@jurajkusnier jurajkusnier merged commit 310db32 into release/2.4.x May 25, 2021
@jurajkusnier jurajkusnier deleted the feature/6008-store_test_result_to_contact_journal branch May 25, 2021 08:44
mtwalli pushed a commit that referenced this pull request May 26, 2021
@jurajkusnier @mtwalli
Contact Journal Extension - Store RAT and PCR Tests results (EXPOSUR…
e7e7657 
…EAPP-6041) (#3238)

* prepare new TestResultRepository

* Code refactoring

* Update tests

* Remove old files

* Code refactoring

* Move TestJournal Table to ContactDiaryDatabase

* remove unused files

* revert DataReset.kt

* rename ContactDiaryTest > ContactDiaryCoronaTest

* rename ContactDiaryTestEntity > ContactDiaryCoronaTestEntity

* add some tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtwalli mtwalli mtwalli approved these changes

@BMItr BMItr BMItr approved these changes

Assignees

@mtwalli mtwalli

@BMItr BMItr

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jurajkusnier @BMItr @mtwalli