This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Basic Layout for Test Certificate Detail Screen (DEV) #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelherbstreith
added
ui
mtwalli
reviewed
May 27, 2021
.../de/rki/coronawarnapp/greencertificate/ui/certificates/details/CertificateDetailsFragment.kt
Outdated
Show resolved
Hide resolved
.../de/rki/coronawarnapp/greencertificate/ui/certificates/details/CertificateDetailsFragment.kt
Outdated
Show resolved
Hide resolved
axelherbstreith
changed the title
mtwalli
reviewed
May 31, 2021
Corona-Warn-App/src/main/res/layout/fragment_greencertificate_details.xml
Show resolved
Hide resolved
mtwalli
reviewed
May 31, 2021
Corona-Warn-App/src/main/res/layout/fragment_greencertificate_details.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_greencertificate_details.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_greencertificate_details.xml
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_greencertificate_details.xml
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/greencertificate_qrcode_card.xml
Outdated
Show resolved
Hide resolved
...i/coronawarnapp/greencertificate/ui/certificates/details/GreenCertificateDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_greencertificate_details.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_greencertificate_details.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_greencertificate_details.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/fragment_greencertificate_details.xml
Outdated
Show resolved
Hide resolved
|
@axelherbstreith @harambasicluka can it be that there's one data input field missing? I didn't find the "Date and Time of Sample Collection | Datum und Uhrzeit der Probenahme" field. |
Nice Catch! This is somehow missing in the Android Figma file. Will clarify with the designers 👍 |
AlexanderAlferov
previously approved these changes
May 31, 2021
There was a problem hiding this comment.
As a basic PR for further development - LGTM 🚀
But please remember to address comments from @mtwalli
This reverts commit bca7c56.
mtwalli
previously approved these changes
May 31, 2021
…//github.com/corona-warn-app/cwa-app-android into feature/dev-test-certificate-detail-fragment
axelherbstreith
dismissed stale reviews from AlexanderAlferov and mtwalli
via
ed2efb0
mtwalli
approved these changes
Jun 1, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Layout for GreenCertificate Detail Screen
To test, pls go to Test Menu -> Green Certificate -> Details Screen
Everything else will be done in a follow-up PR