This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Extend corona test data structures with digital covid certificate related properties (EXPOSUREAPP-7487) #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
d4rken
commented
May 27, 2021
- Extend corona test data structures with digital covid certificate related properties
- Some additional wiring, plumbing and tests for future work.
…ated properties. +Some additional wiring, plumbing and tests for future PRs.
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/coronatest/type/rapidantigen/RapidAntigenProcessor.kt
mtwalli
reviewed
May 28, 2021
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/coronatest/type/pcr/PCRProcessor.kt
Outdated
Show resolved
Hide resolved
…tests' into feature/7487-dgc-properties-for-tests
mtwalli
approved these changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks!
Kudos, SonarCloud Quality Gate passed! |
@@ -38,6 +38,15 @@ interface CoronaTest { | |||
|
|||
val isResultAvailableNotificationSent: Boolean | |||
|
|||
// Is the digital green certificate supported by the point of care that issued the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we now using DCC or DGC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use DCC as it is the official EU name, I will refactor in another PR. If you find it anywhere else, feel free to change it too 😄
chiljamgossow
approved these changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.