Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Extend corona test data structures with digital covid certificate related properties (EXPOSUREAPP-7487) #3309

Merged
merged 10 commits into from May 28, 2021

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented May 27, 2021

  • Extend corona test data structures with digital covid certificate related properties
  • Some additional wiring, plumbing and tests for future work.

…ated properties.

+Some additional wiring, plumbing and tests for future PRs.
@d4rken d4rken added the maintainers Tag pull requests created by maintainers label May 27, 2021
@d4rken d4rken added this to the 2.4.0 milestone May 27, 2021
@d4rken d4rken requested a review from a team May 27, 2021 17:26
# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/coronatest/type/rapidantigen/RapidAntigenProcessor.kt
@chiljamgossow chiljamgossow self-assigned this May 28, 2021
@harambasicluka harambasicluka added the prio PRs to review first. label May 28, 2021
@mtwalli mtwalli self-assigned this May 28, 2021
@d4rken d4rken added the author merge PR to be merged by author label May 28, 2021
@d4rken d4rken marked this pull request as draft May 28, 2021 09:09
@d4rken d4rken removed the author merge PR to be merged by author label May 28, 2021
@d4rken d4rken marked this pull request as ready for review May 28, 2021 10:37
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@sonarcloud
Copy link

sonarcloud bot commented May 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

82.7% 82.7% Coverage
0.0% 0.0% Duplication

@@ -38,6 +38,15 @@ interface CoronaTest {

val isResultAvailableNotificationSent: Boolean

// Is the digital green certificate supported by the point of care that issued the test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we now using DCC or DGC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use DCC as it is the official EU name, I will refactor in another PR. If you find it anywhere else, feel free to change it too 😄

Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@d4rken d4rken merged commit 6870e1a into release/2.4.x May 28, 2021
@d4rken d4rken deleted the feature/7487-dgc-properties-for-tests branch May 28, 2021 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants