Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Target Android 11 (DEV) #3310

Merged
merged 24 commits into from Jun 1, 2021
Merged

Target Android 11 (DEV) #3310

merged 24 commits into from Jun 1, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented May 27, 2021 •
edited

TODO

  • Screenshots tests are not affected by this change

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label May 27, 2021
@mtwalli mtwalli added this to the 2.4.0 milestone May 27, 2021
mtwalli
mtwalli commented May 27, 2021
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@harambasicluka harambasicluka changed the title Target Android 11 Target Android 11 (DEV) May 28, 2021
@d4rken d4rken requested a review from kaddaSz May 28, 2021 07:56
kaddaSz
kaddaSz previously approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@kaddaSz kaddaSz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me...

@mtwalli mtwalli marked this pull request as ready for review May 28, 2021 13:56
@mtwalli mtwalli requested a review from a team May 28, 2021 13:56
@harambasicluka harambasicluka added prio PRs to review first. and removed prio PRs to review first. labels May 31, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

21.7% 21.7% Coverage
0.0% 0.0% Duplication

@d4rken d4rken self-assigned this Jun 1, 2021
d4rken
d4rken approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes lgtm (did not test on device)

@mtwalli mtwalli merged commit 36e77c9 into release/2.4.x Jun 1, 2021
@mtwalli mtwalli deleted the dev/android-11 branch June 1, 2021 15:31
@MikeMcC399 MikeMcC399 mentioned this pull request Jun 1, 2021
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d4rken d4rken d4rken approved these changes

@chiljamgossow chiljamgossow chiljamgossow approved these changes

@kaddaSz kaddaSz kaddaSz left review comments

Assignees

@d4rken d4rken

@kaddaSz kaddaSz

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mtwalli @d4rken @kaddaSz @chiljamgossow @harambasicluka @BMItr