Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Request covid certificate screen (EXPOSUREAPP-7426) #3314

Merged
merged 20 commits into from May 28, 2021
Merged

Request covid certificate screen (EXPOSUREAPP-7426) #3314

merged 20 commits into from May 28, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented May 28, 2021 •
edited

  • Creates request GCC consent screen

Testing

  • Testing menu -> Green certificate -> open screen for both types

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label May 28, 2021
@mtwalli mtwalli added this to the 2.4.0 milestone May 28, 2021
@mtwalli mtwalli added text change PRs with text changes. ui Issue related to UI aspects labels May 28, 2021
@mtwalli mtwalli marked this pull request as ready for review May 28, 2021 11:39
@mtwalli mtwalli requested review from a team May 28, 2021 11:39
@jurajkusnier jurajkusnier self-assigned this May 28, 2021
@BMItr BMItr self-assigned this May 28, 2021
ChristinaTsigganos
ChristinaTsigganos suggested changes May 28, 2021
View reviewed changes
Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix typo in two sentences, then the PR is okay

@BMItr
Copy link
Contributor

BMItr commented May 28, 2021

looking good overall 👌 small comments

@mtwalli mtwalli requested review from chiljamgossow, BMItr and ChristinaTsigganos and removed request for chiljamgossow May 28, 2021 13:28
@sonarcloud
Copy link

sonarcloud bot commented May 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

3.1% 3.1% Coverage
0.0% 0.0% Duplication

ChristinaTsigganos
ChristinaTsigganos approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@mtwalli mtwalli merged commit 64d1452 into release/2.4.x May 28, 2021
@mtwalli mtwalli deleted the feature/7426-request-green-certificate-screen branch May 28, 2021 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jurajkusnier jurajkusnier jurajkusnier approved these changes

@BMItr BMItr BMItr approved these changes

@ChristinaTsigganos ChristinaTsigganos ChristinaTsigganos approved these changes

Assignees

@jurajkusnier jurajkusnier

@BMItr BMItr

Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtwalli @BMItr @jurajkusnier @ChristinaTsigganos