Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Certification screen (EXPOSUREAPP-7433) #3323

Merged
merged 22 commits into from Jun 1, 2021
Merged

Certification screen (EXPOSUREAPP-7433) #3323

merged 22 commits into from Jun 1, 2021

Conversation

jurajkusnier
Copy link
Contributor

@jurajkusnier jurajkusnier commented May 28, 2021 •
edited

Main Cerification screen with some cards. Cards will be adjusted in the following PR.

device-2021-05-31-180554

@jurajkusnier jurajkusnier added maintainers Tag pull requests created by maintainers text change PRs with text changes. labels May 28, 2021
@jurajkusnier jurajkusnier added this to the 2.4.0 milestone May 28, 2021
@jurajkusnier jurajkusnier marked this pull request as ready for review May 31, 2021 16:10
@jurajkusnier jurajkusnier requested review from a team May 31, 2021 16:10
@BMItr BMItr self-assigned this Jun 1, 2021
@jurajkusnier
update strings
b36b734
@jurajkusnier
Merge branch 'release/2.4.x' into feature/7433-certification_screen
e47a55c 
# Conflicts:
#	Corona-Warn-App/src/main/res/values-de/green_certificate_strings.xml
#	Corona-Warn-App/src/main/res/values/green_certificate_strings.xml
ChristinaTsigganos
ChristinaTsigganos previously approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@jurajkusnier
Update CreateVaccinationCard
894ec00
@jurajkusnier
Merge branch 'release/2.4.x' into feature/7433-certification_screen
e5b1b44 
# Conflicts:
#	Corona-Warn-App/src/main/res/navigation/green_certificate_graph.xml
@AlexanderAlferov AlexanderAlferov self-assigned this Jun 1, 2021
AlexanderAlferov
AlexanderAlferov approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a "preparation" pr - LGTM 🚀
Tested on Samsung S8

BMItr
BMItr approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ChristinaTsigganos
ChristinaTsigganos approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jurajkusnier jurajkusnier merged commit 0195d1f into release/2.4.x Jun 1, 2021
@jurajkusnier jurajkusnier deleted the feature/7433-certification_screen branch June 1, 2021 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BMItr BMItr BMItr approved these changes

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

@ChristinaTsigganos ChristinaTsigganos ChristinaTsigganos approved these changes

Assignees

@BMItr BMItr

@AlexanderAlferov AlexanderAlferov

Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jurajkusnier @BMItr @AlexanderAlferov @ChristinaTsigganos