Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Certificates onboarding screen (EXPOSUREAPP-7435) #3337

Merged
merged 10 commits into from Jun 1, 2021

Conversation

AlexanderAlferov
Copy link
Contributor

Certificates onboarding screen.

Screenshot 2021-05-31 at 20 47 31

How to test:
Simply press on Nachweise tab
Screenshot 2021-05-31 at 20 49 16

@AlexanderAlferov AlexanderAlferov added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers text change PRs with text changes. labels May 31, 2021
@AlexanderAlferov AlexanderAlferov added this to the 2.4.0 milestone May 31, 2021
@AlexanderAlferov AlexanderAlferov requested review from jurajkusnier, mtwalli and a team May 31, 2021 17:50
@jurajkusnier jurajkusnier self-assigned this Jun 1, 2021
mtwalli
mtwalli previously approved these changes Jun 1, 2021
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Have not checked on device

@mtwalli mtwalli self-assigned this Jun 1, 2021
@@ -22,6 +23,10 @@ class VaccinationConsentFragmentTest : BaseUITest() {

@MockK lateinit var viewModel: VaccinationConsentViewModel

private val fragmentArgs = VaccinationConsentFragmentArgs(
showBottomNav = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why showBottomNav = false?
BottomNav is visible in Figma.

jurajkusnier
jurajkusnier previously approved these changes Jun 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

8.7% 8.7% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@AlexanderAlferov AlexanderAlferov merged commit f5c2bde into release/2.4.x Jun 1, 2021
@AlexanderAlferov AlexanderAlferov deleted the feature/7435-certificates-info branch June 1, 2021 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants