This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Certificates onboarding screen (EXPOSUREAPP-7435) #3337
Merged
AlexanderAlferov
merged 10 commits into
release/2.4.x
from
feature/7435-certificates-info
Jun 1, 2021
Merged
Certificates onboarding screen (EXPOSUREAPP-7435) #3337
AlexanderAlferov
merged 10 commits into
release/2.4.x
from
feature/7435-certificates-info
Jun 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderAlferov
added
ui
Issue related to UI aspects
maintainers
Tag pull requests created by maintainers
text change
PRs with text changes.
labels
May 31, 2021
mtwalli
previously approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Have not checked on device
jurajkusnier
reviewed
Jun 1, 2021
@@ -22,6 +23,10 @@ class VaccinationConsentFragmentTest : BaseUITest() { | |||
|
|||
@MockK lateinit var viewModel: VaccinationConsentViewModel | |||
|
|||
private val fragmentArgs = VaccinationConsentFragmentArgs( | |||
showBottomNav = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why showBottomNav = false
?
BottomNav is visible in Figma.
jurajkusnier
previously approved these changes
Jun 1, 2021
…orona-warn-app/cwa-app-android into feature/7435-certificates-info
AlexanderAlferov
dismissed stale reviews from jurajkusnier and mtwalli
via
June 1, 2021 10:03
3c72757
mtwalli
approved these changes
Jun 1, 2021
jurajkusnier
approved these changes
Jun 1, 2021
Kudos, SonarCloud Quality Gate passed! |
ChristinaTsigganos
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA approved
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
maintainers
Tag pull requests created by maintainers
text change
PRs with text changes.
ui
Issue related to UI aspects
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certificates onboarding screen.
How to test:
Simply press on Nachweise tab