Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Statistics data for vaccinations (EXPOSUREAPP-7430) #3406

Merged
merged 26 commits into from
Jun 15, 2021
Merged

Statistics data for vaccinations (EXPOSUREAPP-7430) #3406

merged 26 commits into from
Jun 15, 2021

Conversation

SamuraiKek
Copy link
Contributor

@SamuraiKek SamuraiKek commented Jun 10, 2021 •
edited

Adds three new statistics cards with vaccination stats:

  • Persons with one vaccination dose
  • Persons completely vaccinated
  • Applied vaccination rates

Currently only testable with the mock server

@SamuraiKek SamuraiKek added the maintainers Tag pull requests created by maintainers label Jun 10, 2021
@SamuraiKek SamuraiKek added this to the 2.5.0 milestone Jun 10, 2021
@SamuraiKek SamuraiKek requested review from a team June 10, 2021 12:18
NataliaLemmerth
NataliaLemmerth previously approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@harambasicluka harambasicluka changed the title Feature/7430 statistics data for vaccinations Statistics data for vaccinations (EXPOSUREAPP-7430) Jun 10, 2021
@AlexanderAlferov AlexanderAlferov self-assigned this Jun 10, 2021
@jurajkusnier jurajkusnier self-assigned this Jun 10, 2021
jurajkusnier
jurajkusnier reviewed Jun 11, 2021
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cards are not readable when font size is increased. I remember it was one of the requirements when we implement other cards.
image

@SamuraiKek
Copy link
Contributor Author

SamuraiKek commented Jun 11, 2021 •
edited

Cards are not readable when font size is increased. I remember it was one of the requirements when we implement other cards.

Alright, will have a look into it.

jurajkusnier
jurajkusnier approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harambasicluka harambasicluka added the prio PRs to review first. label Jun 15, 2021
@axelherbstreith axelherbstreith self-assigned this Jun 15, 2021
axelherbstreith
axelherbstreith approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@axelherbstreith axelherbstreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍 love that you also added dedicated accessiblility strings 💯

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

5.2% 5.2% Coverage
18.6% 18.6% Duplication

NataliaLemmerth
NataliaLemmerth approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@SamuraiKek SamuraiKek merged commit d931617 into release/2.5.x Jun 15, 2021
@SamuraiKek SamuraiKek deleted the feature/7430-statistics-data-for-vaccinations branch June 15, 2021 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexanderAlferov AlexanderAlferov AlexanderAlferov left review comments

@jurajkusnier jurajkusnier jurajkusnier approved these changes

@axelherbstreith axelherbstreith axelherbstreith approved these changes

@NataliaLemmerth NataliaLemmerth NataliaLemmerth approved these changes

Assignees

@jurajkusnier jurajkusnier

@AlexanderAlferov AlexanderAlferov

@axelherbstreith axelherbstreith

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@SamuraiKek @jurajkusnier @AlexanderAlferov @axelherbstreith @NataliaLemmerth @harambasicluka @mtwalli @BMItr