Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Adjust Test + Vaccination Certificate Detail Screen (EXPOSUREAPP-7671, 7656) #3419

Merged

Conversation

axelherbstreith
Copy link
Contributor

@axelherbstreith axelherbstreith commented Jun 11, 2021

Updated Details Screens for Details Screens for Vaccination + Test Certificates according to figma
-> Attributes in the Vaccination Detail View will be updated once the VaccinationRepository is updated.

Vaccination Detail - Incomplete:
image

Vaccination Detail - Complete:
image

Please test:
Check test certificate by scanning a valid test certificate
Check the vaccination certificate by scanning a valid certificate
-> if the vaccination is incomplete, the card should be grey
-> if the vaccination is complete, the card should be blue

@axelherbstreith axelherbstreith added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Jun 11, 2021
@axelherbstreith axelherbstreith added this to the 2.5.0 milestone Jun 11, 2021
@axelherbstreith axelherbstreith changed the title Adjust Vaccination Detail Screen (EXPOSUREAPP-7656) Adjust Test Certificate Detail Screen (EXPOSUREAPP-7671) Jun 14, 2021
@axelherbstreith axelherbstreith marked this pull request as ready for review June 14, 2021 12:33
@axelherbstreith axelherbstreith requested review from a team June 14, 2021 12:33
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@axelherbstreith axelherbstreith changed the title Adjust Test Certificate Detail Screen (EXPOSUREAPP-7671) Adjust Test + Vaccination Certificate Detail Screen (EXPOSUREAPP-7671) Jun 14, 2021
@axelherbstreith axelherbstreith changed the title Adjust Test + Vaccination Certificate Detail Screen (EXPOSUREAPP-7671) Adjust Test + Vaccination Certificate Detail Screen (EXPOSUREAPP-7671, 7656) Jun 14, 2021
mtwalli
mtwalli previously approved these changes Jun 14, 2021
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mtwalli mtwalli self-assigned this Jun 14, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

1.7% 1.7% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@SamuraiKek SamuraiKek self-assigned this Jun 14, 2021
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axelherbstreith axelherbstreith merged commit 4b4316e into release/2.5.x Jun 14, 2021
@axelherbstreith axelherbstreith deleted the feature/7656-adjust-vaccination-detail-screen branch June 14, 2021 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants