This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Adjust Test + Vaccination Certificate Detail Screen (EXPOSUREAPP-7671, 7656) #3419
Merged
axelherbstreith
merged 26 commits into
release/2.5.x
from
feature/7656-adjust-vaccination-detail-screen
Jun 14, 2021
Merged
Adjust Test + Vaccination Certificate Detail Screen (EXPOSUREAPP-7671, 7656) #3419
axelherbstreith
merged 26 commits into
release/2.5.x
from
feature/7656-adjust-vaccination-detail-screen
Jun 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelherbstreith
added
ui
Issue related to UI aspects
maintainers
Tag pull requests created by maintainers
text change
PRs with text changes.
labels
Jun 11, 2021
axelherbstreith
changed the title
Adjust Vaccination Detail Screen (EXPOSUREAPP-7656)
Adjust Test Certificate Detail Screen (EXPOSUREAPP-7671)
Jun 14, 2021
NataliaLemmerth
previously approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA approved
axelherbstreith
changed the title
Adjust Test Certificate Detail Screen (EXPOSUREAPP-7671)
Adjust Test + Vaccination Certificate Detail Screen (EXPOSUREAPP-7671)
Jun 14, 2021
axelherbstreith
changed the title
Adjust Test + Vaccination Certificate Detail Screen (EXPOSUREAPP-7671)
Adjust Test + Vaccination Certificate Detail Screen (EXPOSUREAPP-7671, 7656)
Jun 14, 2021
mtwalli
previously approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
...ava/de/rki/coronawarnapp/covidcertificate/test/ui/details/CovidCertificateDetailsFragment.kt
Outdated
Show resolved
Hide resolved
...a/de/rki/coronawarnapp/covidcertificate/vaccination/ui/details/VaccinationDetailsFragment.kt
Outdated
Show resolved
Hide resolved
mtwalli
approved these changes
Jun 14, 2021
Kudos, SonarCloud Quality Gate passed! |
NataliaLemmerth
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA approved
SamuraiKek
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
axelherbstreith
deleted the
feature/7656-adjust-vaccination-detail-screen
branch
June 14, 2021 14:39
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
maintainers
Tag pull requests created by maintainers
text change
PRs with text changes.
ui
Issue related to UI aspects
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Details Screens for Details Screens for Vaccination + Test Certificates according to figma
-> Attributes in the Vaccination Detail View will be updated once the VaccinationRepository is updated.
Vaccination Detail - Incomplete:
Vaccination Detail - Complete:
Please test:
Check test certificate by scanning a valid test certificate
Check the vaccination certificate by scanning a valid certificate
-> if the vaccination is incomplete, the card should be grey
-> if the vaccination is complete, the card should be blue