This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Certificates info screen update (EXPOSUREAPP-7661) #3450
Merged
AlexanderAlferov
merged 6 commits into
release/2.5.x
from
feature/7661-certificates-info-screen-update
Jun 16, 2021
Merged
Certificates info screen update (EXPOSUREAPP-7661) #3450
AlexanderAlferov
merged 6 commits into
release/2.5.x
from
feature/7661-certificates-info-screen-update
Jun 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderAlferov
added
ui
Issue related to UI aspects
maintainers
Tag pull requests created by maintainers
text change
PRs with text changes.
labels
Jun 15, 2021
the text in iOS is different, could you please check that ? and which one is up to date ? |
mtwalli
reviewed
Jun 15, 2021
NataliaLemmerth
previously approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA approved
axelherbstreith
previously approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - Darkmode Icons are also in place 👍
AlexanderAlferov
dismissed stale reviews from axelherbstreith and NataliaLemmerth
via
June 15, 2021 16:56
5cd9d8a
…-certificates-info-screen-update # Conflicts: # Corona-Warn-App/src/main/res/values-de/vaccination_strings.xml
mtwalli
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 Thanks!
axelherbstreith
approved these changes
Jun 16, 2021
Kudos, SonarCloud Quality Gate passed! |
NataliaLemmerth
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA approved
AlexanderAlferov
deleted the
feature/7661-certificates-info-screen-update
branch
June 16, 2021 08:00
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
author merge
PR to be merged by author
maintainers
Tag pull requests created by maintainers
text change
PRs with text changes.
ui
Issue related to UI aspects
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted certificates info screen (with new legal strings 🤩).