Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Link to FAQ if Certificate is not available (EXPOSUREAPP-7846) #3454

Merged
merged 14 commits into from
Jun 16, 2021
Merged

Link to FAQ if Certificate is not available (EXPOSUREAPP-7846) #3454

merged 14 commits into from
Jun 16, 2021

Conversation

kolyaopahle
Copy link
Contributor

@kolyaopahle kolyaopahle commented Jun 15, 2021 •
edited

Description

This PR adds a new error state described in the following tech spec pr: https://github.com/corona-warn-app/cwa-app-tech-spec/pull/73
to the test certificate flow for pcr tests

Steps to reproduce

  1. register a negative pcr test with dgc support in an env that does not supply labId bin/cli -e *ENV* pcr --dgc true -r negative
  2. request a certificate for the test
  3. check if the certificate fails to fetch in the certificate tab
  4. press retry and check if the warning in the screenshot is shown (only german text atm)

@kolyaopahle kolyaopahle added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers labels Jun 15, 2021
@kolyaopahle kolyaopahle added this to the 2.4.0 milestone Jun 15, 2021
@kolyaopahle kolyaopahle requested review from a team June 15, 2021 13:53
@chiljamgossow chiljamgossow self-assigned this Jun 15, 2021
@harambasicluka harambasicluka added the prio PRs to review first. label Jun 16, 2021
@BMItr BMItr self-assigned this Jun 16, 2021
@chiljamgossow chiljamgossow removed their assignment Jun 16, 2021
@BMItr
Copy link
Contributor

BMItr commented Jun 16, 2021 •
edited

oneplus

tested on oneplus 8 successfully.
code lgtm

@BMItr
Copy link
Contributor

BMItr commented Jun 16, 2021 •
edited

ps: faq link working
ps2: wrote you a PM for potential FollowUp PR

NataliaLemmerth
NataliaLemmerth approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@chris-cwa chris-cwa self-assigned this Jun 16, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

11.8% 11.8% Coverage
7.5% 7.5% Duplication

@harambasicluka harambasicluka merged commit e7e16f2 into release/2.4.x Jun 16, 2021
@harambasicluka harambasicluka deleted the feature/7846-lab-id-issue-dialog branch June 16, 2021 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BMItr BMItr BMItr approved these changes

@chris-cwa chris-cwa chris-cwa approved these changes

@NataliaLemmerth NataliaLemmerth NataliaLemmerth approved these changes

Assignees

@BMItr BMItr

@chris-cwa chris-cwa

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first. ui Issue related to UI aspects
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kolyaopahle @BMItr @chris-cwa @NataliaLemmerth @chiljamgossow @harambasicluka