Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix analytics reportAdvancedConsentGiven not being called on every navigation path (DEV) #3460

Merged
merged 3 commits into from
Jun 15, 2021

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Jun 15, 2021

Fix missing Analytics.reportAdvancedConsentGiven in RequestCovidCertificateViewModel, by refactoring and moving the analytics call into the common TestRegistrationStateProcessor.

…tificateViewModel, by refactoring and moving the analytics call into the common TestRegistrationStateProcessor.
@d4rken d4rken added bug Something isn't working maintainers Tag pull requests created by maintainers labels Jun 15, 2021
@d4rken d4rken added this to the 2.4.0 milestone Jun 15, 2021
@d4rken d4rken requested a review from a team June 15, 2021 15:54
@chiljamgossow chiljamgossow self-assigned this Jun 15, 2021
@mtwalli mtwalli self-assigned this Jun 15, 2021
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit 2343c97 into release/2.4.x Jun 15, 2021
@mtwalli mtwalli deleted the fix/DEV-analytics-advanced-consent branch June 15, 2021 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants