Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix: pending DCC label (EXPOSUREAPP-7848) #3468

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Conversation

AlexanderAlferov
Copy link
Contributor

Fix incorrect label for DCC on pending page.

Aligned with QA: switched from overall consent (isAdvancedConsentGiven) to precise DCC consent flag (isDccConsentGiven).
This consent is given in RequestCovidCertificateFragment:

agreeButton.setOnClickListener { viewModel.onAgreeGC() }
disagreeButton.setOnClickListener { viewModel.onDisagreeGC() }

How to test:

  1. Install the app
  2. Complete onboarding
  3. Scan pending PCR test
  4. On COVID-Testsecrtificate press "Testzertifikat Anfordern" button
  5. Check that on next page bottom icon item (with QR-code icon) is in this state:

Screenshot 2021-06-16 at 14 27 57

  1. Delete test
  2. Scan pending PCR test
  3. On COVID-Testsecrtificate press "Nein Danke" button
  4. Check that on next page bottom icon item (with QR-code icon) is in this state:

Screenshot 2021-06-16 at 14 30 57

@AlexanderAlferov AlexanderAlferov added maintainers Tag pull requests created by maintainers Fix 2.4 Fix is planned for 2.4 labels Jun 16, 2021
@AlexanderAlferov AlexanderAlferov requested a review from a team June 16, 2021 11:41
@mtwalli mtwalli self-assigned this Jun 16, 2021
@harambasicluka harambasicluka added this to the 2.4.0 milestone Jun 16, 2021
@BMItr BMItr self-assigned this Jun 16, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit e86a401 into release/2.4.x Jun 16, 2021
@mtwalli mtwalli deleted the fix/7848-pending-dcc branch June 16, 2021 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fix 2.4 Fix is planned for 2.4 maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants