This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Don't start ESL on app start in test build (EXPOSUREAPP-7946) #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… installed. This allows us to both disable it by default, but still have a way to log the initial app launch if necessary (or have it automatically enabled by just having the package installed).
d4rken
added
enhancement
|
Could this be a step towards community test builds? Because it looks like this PR could solve related legal issues... |
This is just about making life easier for the testers and people responsible for the internal build pipelines. |
|
Hint: Use |
harambasicluka
previously approved these changes
Jun 16, 2021
…terbuilds' into feature/7946-els-autologging-testerbuilds
harambasicluka
approved these changes
Jun 16, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
In tester builders, the app is automatically recording a debuglog, it does not have to be explicitly started.
Now:
Enable ELS autologging in tester builds only if a specific package is installed (
de.rki.coronawarnapp.els.autologger).This allows us to both disable it by default, and still have a way to log the initial app launch if necessary, or have it automatically enabled by just having the package installed.
CWA-ELS-AutoLogger-de.rki.coronawarnapp.els.autologger.zip