This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Cannot obtain test certificate after deleting pending/failed test certificate (EXPOSUREAPP-7763) #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove catch clause from flow as this would cancel it and replace it with a try catch in the on each callback
kolyaopahle
added
backend
kolyaopahle
changed the title
d4rken
approved these changes
Jun 16, 2021
| if (checkCerts) scheduleWorker() | ||
| try { | ||
| Timber.tag(TAG).d("State change: checkCerts=$checkCerts") | ||
| if (checkCerts) scheduleWorker() |
There was a problem hiding this comment.
I don't think this could reasonably throw an exception, but catching it doesn't hurt either.
There was a problem hiding this comment.
i agree, i did it here for consistency with the other occasions, but we could remove it as well.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes a bit of logic during certifiacte creation where currently one failed certificate creation would result in the flow completing and no more certs being created untill the app is restarted.
Steps to reproduce
de.rki.coronawarnapp.covidcertificate.test.core.TestCertificateRepository#requestCertificatewould have to throw an error