Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Sharing dialog error adjustment (EXPOSUREAPP-7116) #3499

Merged
merged 6 commits into from
Jun 18, 2021

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented Jun 18, 2021

This PR addresses Exposureapp-7116.

How to test:
Steps:
App is installed
tap on "share error log"
switch off wifi
confirm and try to send the els

Expected result:
correct error message regarding the els sharing process
Text for the error message in ELS: "Der Fehlerbericht kann aktuell nicht gesendet werden. Bitte versuchen Sie es später noch einmal."

before PR Result:
"Die Befragung kann aktuell nicht aufgerufen werden. ..."

@BMItr BMItr requested review from a team June 18, 2021 13:53
@BMItr BMItr changed the base branch from main to release/2.5.x June 18, 2021 13:53
@BMItr BMItr added this to the 2.5.0 milestone Jun 18, 2021
@BMItr BMItr added maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Jun 18, 2021
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@axelherbstreith axelherbstreith self-assigned this Jun 18, 2021
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mtwalli mtwalli self-assigned this Jun 18, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@d4rken d4rken merged commit b9b1cc2 into release/2.5.x Jun 18, 2021
@d4rken d4rken deleted the fix/7116-sharing-dialog-adjustment branch June 18, 2021 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants