Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix Statistic Card Label (DEV) #3503

Merged
merged 10 commits into from
Jun 21, 2021

Conversation

axelherbstreith
Copy link
Contributor

@axelherbstreith axelherbstreith commented Jun 18, 2021

Small Fix for the Statistics Card Labels:

Almost all Statistics Card Labels currently used the formatting of the `AppliedVaccinationRatesStats since the cases were only separated by a comma. Adding handling to all elements in the switch case avoids this issue.

Before:
image

after:
image

@axelherbstreith axelherbstreith added the maintainers Tag pull requests created by maintainers label Jun 18, 2021
@axelherbstreith axelherbstreith added this to the 2.5.0 milestone Jun 18, 2021
@axelherbstreith axelherbstreith requested a review from a team June 18, 2021 15:46
@BMItr BMItr self-assigned this Jun 18, 2021
@d4rken d4rken self-assigned this Jun 21, 2021
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 4 Code Smells

44.2% 44.2% Coverage
0.0% 0.0% Duplication

@axelherbstreith axelherbstreith merged commit 1c14bda into release/2.5.x Jun 21, 2021
@axelherbstreith axelherbstreith deleted the fix/dev_statistics_card_labels branch June 21, 2021 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants