Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix deadman notification delay (EXPOSUREAPP-7955) #3533

Merged
merged 7 commits into from
Jun 24, 2021

Conversation

chiljamgossow
Copy link
Contributor

@chiljamgossow chiljamgossow commented Jun 23, 2021

use createdAt timestamp to calculate delay of notification (not the package date)

Scenario: metered connection -> only day packages. In the morning of 06/23 it will download package 06/22. Before it would take the date at start of the day and plan a notification in 36h minus the age of the downladed package - which is already 24h hours old when it was downloaded. So 12h later the day the user gets the notification - despite having a daily download

@chiljamgossow chiljamgossow added maintainers Tag pull requests created by maintainers author merge PR to be merged by author labels Jun 23, 2021
@chiljamgossow chiljamgossow added this to the 2.5.0 milestone Jun 23, 2021
@chiljamgossow chiljamgossow requested a review from a team June 23, 2021 14:57
@chiljamgossow chiljamgossow changed the title Fix/7955 deadman Fix deadman notification delay (EXPOSUREAPP-7955) Jun 23, 2021
@AlexanderAlferov AlexanderAlferov self-assigned this Jun 23, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@chiljamgossow chiljamgossow removed the author merge PR to be merged by author label Jun 23, 2021
Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurajkusnier jurajkusnier merged commit d4ee62b into release/2.5.x Jun 24, 2021
@jurajkusnier jurajkusnier deleted the fix/7955-deadman branch June 24, 2021 06:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants