Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix an addtional popup in redeemed test (EXPOSUREAPP-7893) #3537

Merged
merged 5 commits into from
Jun 24, 2021

Conversation

jurajkusnier
Copy link
Contributor

@jurajkusnier jurajkusnier commented Jun 23, 2021

remove generic error for AlreadyRedeemedException as we handle it later in TestRegistrationStateProcessor

Testing

  • scan redeemed PCR test QR Code
    or
  • use cwa server with updated .server-config.yml to get always redeemed response
      - name: /version/v1/testresult
        responseId: 200+4

@jurajkusnier jurajkusnier added bug Something isn't working maintainers Tag pull requests created by maintainers labels Jun 23, 2021
@jurajkusnier jurajkusnier added this to the 2.5.0 milestone Jun 23, 2021
@jurajkusnier jurajkusnier requested a review from a team June 23, 2021 20:13
@AlexanderAlferov AlexanderAlferov self-assigned this Jun 24, 2021
@AlexanderAlferov
Copy link
Contributor

According to Jira ticket 21 days popup is expected. I recieve this error:

Screenshot 2021-06-24 at 11 42 10

Steps:

  1. create new test PCR QR code (wru, negative)
  2. scan
  3. delete it
  4. scan again

@jurajkusnier
Copy link
Contributor Author

According to Jira ticket 21 days popup is expected. I recieve this error:

Screenshot 2021-06-24 at 11 42 10

Steps:

1. create new test PCR QR code (wru, negative)

2. scan

3. delete it

4. scan again

21 days popup is expected for redeemed QR codes. If you scan the same QR code twice you get the right error message saying "The QR Code is invalid or has been registered".

@harambasicluka harambasicluka changed the title FIx an addtional popup in redeemed test (EXPOSUREAPP-7893) Fix an addtional popup in redeemed test (EXPOSUREAPP-7893) Jun 24, 2021
@SamuraiKek SamuraiKek self-assigned this Jun 24, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@SamuraiKek SamuraiKek merged commit 2db05cb into release/2.5.x Jun 24, 2021
@SamuraiKek SamuraiKek deleted the fix/7893-redeemed_test branch June 24, 2021 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants