This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Show pending test certificates (DEV) #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
added
bug
AlexanderAlferov
approved these changes
Jun 24, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
TestCertificateContainer.toTestCertificate()returnsnullwhenTestCertificateis pending and this prevent it from showing up in the UI layerInstead of making the fields in TestCertificate optional when it is pending , I reply on the
TestCertificateWrapperto show items for pending TestCertificates in the PersonOverview screen
Steps to produce:
1- Scan a Corona Test
2- Request DGC
3- Open Certificates Tab pending certificates should appear
TODO
Tests + screenshots test to be updated in a follow up PR