Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Missing person overview screenshots (EXPOSUREAPP-8231) #3618

Merged
merged 6 commits into from
Jul 5, 2021

Conversation

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Jul 2, 2021
@mtwalli mtwalli added this to the 2.5.0 milestone Jul 2, 2021
@mtwalli mtwalli requested a review from a team July 2, 2021 13:46
@mtwalli mtwalli added the bug Something isn't working label Jul 2, 2021
@mtwalli mtwalli changed the title More screenshots (EXPOSUREAPP-8231) Missing person overview screenshots (EXPOSUREAPP-8231) Jul 2, 2021
@harambasicluka
Copy link
Contributor

I think you also changed this screenshot, but we need it exactly this way with this order of persons, with this names...
PersonOverviewFragment_persons

@mtwalli
Copy link
Contributor Author

mtwalli commented Jul 2, 2021

I think you also changed this screenshot, but we need it exactly this way with this order of persons, with this names...
PersonOverviewFragment_persons

It is there also, I scroll to display all of them and capture the screen, they can publish what they like

Screen 1

Person 1
Person 2

Screen 2

Person 2
Person 3

Screen 3

Person 3

Screen 4

Person 1 only

What is needed is Screen 1 and Screen 4 , Screen 2 and Screen 3 are extra spices 😃

@d4rken d4rken added the prio PRs to review first. label Jul 2, 2021
@harambasicluka harambasicluka self-assigned this Jul 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@axelherbstreith axelherbstreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@axelherbstreith axelherbstreith merged commit 9e65521 into release/2.5.x Jul 5, 2021
@axelherbstreith axelherbstreith deleted the fix/8231-person-overview-screenshots branch July 5, 2021 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants