Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

General error message handling for invalid certificates (DEV) #3628

Merged
merged 10 commits into from
Jul 5, 2021
Merged

General error message handling for invalid certificates (DEV) #3628

merged 10 commits into from
Jul 5, 2021

Conversation

chiljamgossow
Copy link
Contributor

move general certificate error handling to InvalidHealthCertificateException

@chiljamgossow chiljamgossow requested review from a team July 5, 2021 08:23
@chiljamgossow chiljamgossow added the maintainers Tag pull requests created by maintainers label Jul 5, 2021
@chiljamgossow chiljamgossow added this to the 2.5.0 milestone Jul 5, 2021
@chiljamgossow chiljamgossow changed the title Fix error message for invalid certificates (DEV) Fix error message handling for invalid certificates (DEV) Jul 5, 2021
@chiljamgossow chiljamgossow changed the title Fix error message handling for invalid certificates (DEV) General error message handling for invalid certificates (DEV) Jul 5, 2021
NataliaLemmerth
NataliaLemmerth previously approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

@chiljamgossow chiljamgossow added the prio PRs to review first. label Jul 5, 2021
harambasicluka
harambasicluka suggested changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the id only in german and add it to values (do not delete the old ones), everything else will be handled by the translation delivery.

@chiljamgossow chiljamgossow force-pushed the fix/error-message-invalid-certificate branch from 455a390 to 834e30d Compare July 5, 2021 10:50
@mtwalli mtwalli self-assigned this Jul 5, 2021
harambasicluka
harambasicluka reviewed Jul 5, 2021
View reviewed changes
Copy link
Contributor

@harambasicluka harambasicluka left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings look fine! but somehow the linter complains O.o

mtwalli
mtwalli previously approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.4% 70.4% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit c4eb409 into release/2.5.x Jul 5, 2021
@harambasicluka harambasicluka deleted the fix/error-message-invalid-certificate branch July 5, 2021 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harambasicluka harambasicluka harambasicluka approved these changes

@mtwalli mtwalli mtwalli left review comments

@NataliaLemmerth NataliaLemmerth Awaiting requested review from NataliaLemmerth

Assignees

@mtwalli mtwalli

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chiljamgossow @mtwalli @harambasicluka @NataliaLemmerth