Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Implement error dialog on scanning for invalid signatures (EXPOSUREAPP-8367) #3800

Merged
merged 57 commits into from
Jul 27, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Jul 23, 2021

After: #3779

Screenshot 2021-07-26 at 11 38 47

mtwalli and others added 30 commits July 19, 2021 12:47
@mtwalli mtwalli changed the base branch from release/2.7.x to feature/8365-signature-validation July 26, 2021 09:09
@BMItr BMItr self-assigned this Jul 26, 2021
BMItr
BMItr previously approved these changes Jul 26, 2021
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mtwalli
Copy link
Contributor Author

mtwalli commented Jul 26, 2021

lgtm!

Nice review 😄

Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor issue, please add a period at end of sentence

Base automatically changed from feature/8365-signature-validation to release/2.7.x July 27, 2021 11:17
Copy link
Contributor

@ChristinaTsigganos ChristinaTsigganos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d4rken d4rken self-assigned this Jul 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

26.2% 26.2% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit ed16b9c into release/2.7.x Jul 27, 2021
@mtwalli mtwalli deleted the feature/8367-dialog branch July 27, 2021 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants