This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Implement error dialog on scanning for invalid signatures (EXPOSUREAPP-8367) #3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/corona-warn-app/cwa-app-android into feature/8365-signature-validation
…m/corona-warn-app/cwa-app-android into feature/8365-signature-validation
…m/corona-warn-app/cwa-app-android into feature/8365-signature-validation
…m/corona-warn-app/cwa-app-android into feature/8365-signature-validation
mtwalli
changed the base branch from
release/2.7.x
to
feature/8365-signature-validation
July 26, 2021 09:09
mtwalli
force-pushed
the
feature/8367-dialog
branch
from
July 26, 2021 09:17
470b70a
to
9b25402
Compare
BMItr
reviewed
Jul 26, 2021
.../de/rki/coronawarnapp/covidcertificate/common/exception/InvalidHealthCertificateException.kt
Show resolved
Hide resolved
BMItr
reviewed
Jul 26, 2021
.../de/rki/coronawarnapp/covidcertificate/common/exception/InvalidHealthCertificateException.kt
Show resolved
Hide resolved
BMItr
reviewed
Jul 26, 2021
.../de/rki/coronawarnapp/covidcertificate/common/exception/InvalidHealthCertificateException.kt
Show resolved
Hide resolved
BMItr
previously approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Nice review 😄 |
Corona-Warn-App/src/main/res/values-de/covid_certificate_strings.xml
Outdated
Show resolved
Hide resolved
ChristinaTsigganos
suggested changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just minor issue, please add a period at end of sentence
Base automatically changed from
feature/8365-signature-validation
to
release/2.7.x
July 27, 2021 11:17
ChristinaTsigganos
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA approved
d4rken
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After: #3779