This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
RSA Algo unit-test (DEV) #3821
Merged
RSA Algo unit-test (DEV) #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelherbstreith
approved these changes
Jul 28, 2021
| @@ -44,6 +46,9 @@ class DscSignatureValidatorTest : BaseTest() { | |||
| every { dscRepository.dscData } returns flowOf(dscData) | |||
| every { securityProvider.setup() } just Runs | |||
|
|
|||
| // Add RSA algorithm in unit tests context. | |||
| Security.addProvider(BouncyCastleProvider()) | |||
There was a problem hiding this comment.
Does this need to removed again?
There was a problem hiding this comment.
No, it will stay. SecurityProvider.setup() should NOT be mocked ,but the crypto stuff from org.conscrypt.* is not available for unit testing. we could use an openJDK implementation ,but it is not really worth it for one unit test, more information here. google/conscrypt#649
There was a problem hiding this comment.
For the actual App SecurityProvider will be doing that ,but it is not a issue for the real app
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/corona-warn-app/cwa-app-tech-spec/commit/4ff61c569e15cb52615c1635c8c795674af322a1