Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Improve scrolling behavior in validation result screen (COMMUNITY) #3835

Conversation

fynngodau
Copy link
Contributor

In the validation result screen, the header image currently disappears so late that it can overlap with the text too much, which doesn't look great (see video demonstration below).

To improve the result screens, this PR contains the following changes:

  • Separate gradient from background header vector asset (it is not quite a 1:1 reproduction but good enough).
  • Attach OnOffsetChangedListener to bar layout through pre-existing AppBarLayout.OnOffsetChangedListener extension function to hide the header image at the same rate as e.g. the Europe background image on the vaccination details screen so that it disappears quicker and overlaps less with the toolbar text for a smoother experience.
  • Show gradient in toolbar even if it is collapsed, like is the case for RAT, event organizer, event attendee, vaccination, …, screens.

Previously

cwa-certificate-result-prev.mp4

After

cwa-certificate-result.mp4

@fynngodau fynngodau requested a review from a team July 29, 2021 10:49
@harambasicluka harambasicluka added the community Tag issues created by community members label Jul 29, 2021
@harambasicluka harambasicluka added this to the 2.7.0 milestone Jul 29, 2021
@mtwalli mtwalli self-assigned this Jul 29, 2021
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice attention to details <3

@mtwalli mtwalli merged commit c130c22 into corona-warn-app:release/2.7.x Aug 2, 2021
@fynngodau fynngodau deleted the enhance/validation-result-scroll branch August 3, 2021 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Tag issues created by community members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants